From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, bigeasy@linutronix.de
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10.y] clocksource/i8253: Use raw_spinlock_irqsave() in clockevent_i8253_disable()
Date: Tue, 13 May 2025 14:50:42 -0400 [thread overview]
Message-ID: <20250513080408-03c3b9e248f87d0b@stable.kernel.org> (raw)
In-Reply-To: <20250513070201.488210-1-bigeasy@linutronix.de>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it
Found matching upstream commit: 94cff94634e506a4a44684bee1875d2dbf782722
Status in newer kernel trees:
6.14.y | Present (different SHA1: 6fdc7368341b)
6.12.y | Present (different SHA1: e0e66bb1af60)
6.6.y | Present (different SHA1: 5dd520b92acb)
6.1.y | Present (different SHA1: d2f5f71707cf)
5.15.y | Present (different SHA1: f29f5341f350)
Note: The patch differs from the upstream commit:
---
1: 94cff94634e50 ! 1: 2a4e575499d58 clocksource/i8253: Use raw_spinlock_irqsave() in clockevent_i8253_disable()
@@ Commit message
raw_spinlock_irqsave() to cure this.
[ tglx: Massage change log and use guard() ]
+ [ bigeasy: Dropped guard() for stable ]
Fixes: c8c4076723dac ("x86/timer: Skip PIT initialization on modern chipsets")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20250404133116.p-XRWJXf@linutronix.de
+ (cherry picked from commit 94cff94634e506a4a44684bee1875d2dbf782722)
+ Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
## drivers/clocksource/i8253.c ##
@@ drivers/clocksource/i8253.c: int __init clocksource_i8253_init(void)
@@ drivers/clocksource/i8253.c: int __init clocksource_i8253_init(void)
void clockevent_i8253_disable(void)
{
- raw_spin_lock(&i8253_lock);
-+ guard(raw_spinlock_irqsave)(&i8253_lock);
++ unsigned long flags;
++
++ raw_spin_lock_irqsave(&i8253_lock, flags);
/*
* Writing the MODE register should stop the counter, according to
@@ drivers/clocksource/i8253.c: void clockevent_i8253_disable(void)
- outb_p(0, PIT_CH0);
outb_p(0x30, PIT_MODE);
--
+
- raw_spin_unlock(&i8253_lock);
++ raw_spin_unlock_irqrestore(&i8253_lock, flags);
}
static int pit_shutdown(struct clock_event_device *evt)
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.10.y | Success | Success |
prev parent reply other threads:[~2025-05-13 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 10:31 FAILED: patch "[PATCH] clocksource/i8253: Use raw_spinlock_irqsave() in" failed to apply to 5.10-stable tree gregkh
2025-05-13 7:02 ` [PATCH 5.10.y] clocksource/i8253: Use raw_spinlock_irqsave() in clockevent_i8253_disable() Sebastian Andrzej Siewior
2025-05-13 18:50 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513080408-03c3b9e248f87d0b@stable.kernel.org \
--to=sashal@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox