From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Feng Tang <feng.tang@linux.alibaba.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1.y] selftests/mm: compaction_test: support platform with huge mount of memory
Date: Tue, 13 May 2025 14:49:51 -0400 [thread overview]
Message-ID: <20250513112902-67c201360cff774d@stable.kernel.org> (raw)
In-Reply-To: <20250513055831.93239-1-feng.tang@linux.alibaba.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: ab00ddd802f80e31fc9639c652d736fe3913feae
Status in newer kernel trees:
6.14.y | Present (different SHA1: cc09dec6cce3)
6.12.y | Present (different SHA1: 72669f82feb1)
6.6.y | Not found
Note: The patch differs from the upstream commit:
---
1: ab00ddd802f80 ! 1: a22426c38dd6a selftests/mm: compaction_test: support platform with huge mount of memory
@@ Metadata
## Commit message ##
selftests/mm: compaction_test: support platform with huge mount of memory
+ commit ab00ddd802f80e31fc9639c652d736fe3913feae upstream.
+
When running mm selftest to verify mm patches, 'compaction_test' case
failed on an x86 server with 1TB memory. And the root cause is that it
has too much free memory than what the test supports.
@@ Commit message
Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>
Acked-by: Dev Jain <dev.jain@arm.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
- Tested-by: Baolin Wang <baolin.wang@inux.alibaba.com>
+ Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
- ## tools/testing/selftests/mm/compaction_test.c ##
-@@ tools/testing/selftests/mm/compaction_test.c: int check_compaction(unsigned long mem_free, unsigned long hugepage_size,
+ ## tools/testing/selftests/vm/compaction_test.c ##
+@@ tools/testing/selftests/vm/compaction_test.c: int check_compaction(unsigned long mem_free, unsigned long hugepage_size)
int compaction_index = 0;
+ char initial_nr_hugepages[20] = {0};
char nr_hugepages[20] = {0};
- char init_nr_hugepages[24] = {0};
+ char target_nr_hugepages[24] = {0};
+ int slen;
- snprintf(init_nr_hugepages, sizeof(init_nr_hugepages),
- "%lu", initial_nr_hugepages);
-@@ tools/testing/selftests/mm/compaction_test.c: int check_compaction(unsigned long mem_free, unsigned long hugepage_size,
- goto out;
- }
+ /* We want to test with 80% of available memory. Else, OOM killer comes
+ in to play */
+@@ tools/testing/selftests/vm/compaction_test.c: int check_compaction(unsigned long mem_free, unsigned long hugepage_size)
+
+ lseek(fd, 0, SEEK_SET);
- /* Request a large number of huge pages. The Kernel will allocate
- as much as it can */
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Success |
prev parent reply other threads:[~2025-05-13 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 9:20 FAILED: patch "[PATCH] selftests/mm: compaction_test: support platform with huge" failed to apply to 6.1-stable tree gregkh
2025-05-13 5:58 ` [PATCH 6.1.y] selftests/mm: compaction_test: support platform with huge mount of memory Feng Tang
2025-05-13 18:49 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513112902-67c201360cff774d@stable.kernel.org \
--to=sashal@kernel.org \
--cc=feng.tang@linux.alibaba.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox