From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Zhaoyang Li <lizy04@hust.edu.cn>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1.y] bnxt_en: Fix receive ring space parameters when XDP is active
Date: Wed, 14 May 2025 16:14:14 -0400 [thread overview]
Message-ID: <20250514104750-efaeb21d7ed44842@stable.kernel.org> (raw)
In-Reply-To: <20250514064438.395697-1-lizy04@hust.edu.cn>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 3051a77a09dfe3022aa012071346937fdf059033
WARNING: Author mismatch between patch and upstream commit:
Backport author: Zhaoyang Li<lizy04@hust.edu.cn>
Commit author: Shravya KN<shravya.k-n@broadcom.com>
Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.12.y | Present (different SHA1: 84353386762a)
6.6.y | Present (different SHA1: 7f306c651fea)
Note: The patch differs from the upstream commit:
---
1: 3051a77a09dfe ! 1: ac412781f87ea bnxt_en: Fix receive ring space parameters when XDP is active
@@ Metadata
## Commit message ##
bnxt_en: Fix receive ring space parameters when XDP is active
+ [ Upstream commit 3051a77a09dfe3022aa012071346937fdf059033 ]
+
The MTU setting at the time an XDP multi-buffer is attached
determines whether the aggregation ring will be used and the
rx_skb_func handler. This is done in bnxt_set_rx_skb_mode().
@@ Commit message
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+ Signed-off-by: Zhaoyang Li <lizy04@hust.edu.cn>
+
## drivers/net/ethernet/broadcom/bnxt/bnxt.c ##
@@ drivers/net/ethernet/broadcom/bnxt/bnxt.c: int bnxt_set_rx_skb_mode(struct bnxt *bp, bool page_mode)
struct net_device *dev = bp->dev;
@@ drivers/net/ethernet/broadcom/bnxt/bnxt.c: int bnxt_set_rx_skb_mode(struct bnxt
@@ drivers/net/ethernet/broadcom/bnxt/bnxt.c: static int bnxt_change_mtu(struct net_device *dev, int new_mtu)
bnxt_close_nic(bp, true, false);
- WRITE_ONCE(dev->mtu, new_mtu);
+ dev->mtu = new_mtu;
+
+ /* MTU change may change the AGG ring settings if an XDP multi-buffer
+ * program is attached. We need to set the AGG rings settings and
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Success |
prev parent reply other threads:[~2025-05-14 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 6:44 [PATCH 6.1.y] bnxt_en: Fix receive ring space parameters when XDP is active Zhaoyang Li
2025-05-14 20:14 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514104750-efaeb21d7ed44842@stable.kernel.org \
--to=sashal@kernel.org \
--cc=lizy04@hust.edu.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox