From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E54B215F6C; Thu, 15 May 2025 15:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747322951; cv=none; b=VUbpvhiSk9G9xpQaAWErI7bCQ0y2R4UBnb0mPP3uL0+bxoN1QixLosVORiqdFJ4SMH+n8rh6+JpElAGnPJzHmCaEX9EgSJg24Wgj0v4Z0GDDrcKMcK/aHgtW7fWIrRam1DjIIOJP7OBWyssPin6p+HeflpJtBwrHBjkqZdXXJjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747322951; c=relaxed/simple; bh=wzY+6d/sGnmcDJMn4ZDQ5jNioYD2ve8+ymqCu8LJxn4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MuAI1Z9dz+oO5JrQgSSrzpkUlFvq+lXMXHsY3yC0+Dj0yB9yA2sG8uf1JeGBeKMFYVeYVTQoLh5rs//kUhqUwrC4n/vLGWT0U/IX4d/EShWNptO/MBOgtnvQ77TJXe3kEDa1WyVC+SUl1qwfwDpcpB7dCwKFIDcYcBDqLDbY3kY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=H0/eBXaN; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="H0/eBXaN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747322949; x=1778858949; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=wzY+6d/sGnmcDJMn4ZDQ5jNioYD2ve8+ymqCu8LJxn4=; b=H0/eBXaNAe89FwXAo0V0150EZYTueLMfQnPn9v295MchETBw3PhVW9mE sTWhzd1BklwSPB6cOUf5OwBCXMGiG67H8R4V8yiJ1fd48ZZaaxgxOGxB6 hVl8buTtJEIt3cSD49EZL2sWKd29v/1asR7IKgC4AZXzgRVx8WaCdsXw9 WpcckqNicjnOn/twLRjp4h/u9j9ES6I75Wx0tQvND0optiomS1HMwcJd9 Aa8yLpQBqnzufXvBao0BLCcoWSnmCMHb2WkV/qxir2kWQKcGaQnxQn/nq b4ydOQHl/l0FtYQOrryZdT69ltuKvuXGGYfBcgifmqslHZHcD2TdpIrKq w==; X-CSE-ConnectionGUID: zj1yJUZfQRq//toGZmlMQg== X-CSE-MsgGUID: Bp/g86dqQTSQX/PZULlG1A== X-IronPort-AV: E=McAfee;i="6700,10204,11434"; a="60285042" X-IronPort-AV: E=Sophos;i="6.15,291,1739865600"; d="scan'208";a="60285042" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2025 08:29:08 -0700 X-CSE-ConnectionGUID: IgnFK8KoTEyhykzgNMormA== X-CSE-MsgGUID: XE+ntt9zSKCmZ8lx6SbkdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,291,1739865600"; d="scan'208";a="138940815" Received: from gkhatri-mobl.amr.corp.intel.com (HELO desk) ([10.125.146.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2025 08:29:07 -0700 Date: Thu, 15 May 2025 08:29:00 -0700 From: Pawan Gupta To: Greg Kroah-Hartman Cc: Guenter Roeck , Harshit Mogalapalli , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, hargar@microsoft.com, broonie@kernel.org, Darren Kenny Subject: Re: [PATCH 6.6 000/113] 6.6.91-rc2 review Message-ID: <20250515152900.vk3vbotiedv2temq@desk> References: <20250514125617.240903002@linuxfoundation.org> <861004b4-e036-4306-b129-252b9cb983c7@oracle.com> <2025051440-sturdily-dragging-3843@gregkh> <9af6afb1-9d91-48ea-a212-bcd6d1a47203@oracle.com> <2025051527-travesty-shape-0e3b@gregkh> <20250515152557.a4q2cqab4uvhnpia@desk> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250515152557.a4q2cqab4uvhnpia@desk> On Thu, May 15, 2025 at 08:26:04AM -0700, Pawan Gupta wrote: > On Thu, May 15, 2025 at 07:35:26AM +0200, Greg Kroah-Hartman wrote: > > On Wed, May 14, 2025 at 01:49:06PM -0700, Guenter Roeck wrote: > > > On 5/14/25 13:33, Harshit Mogalapalli wrote: > > > > Hi Greg, > > > > > > > > On 15/05/25 01:35, Greg Kroah-Hartman wrote: > > > > > On Thu, May 15, 2025 at 12:29:40AM +0530, Harshit Mogalapalli wrote: > > > > > > Hi Greg, > > > > > > On 14/05/25 18:34, Greg Kroah-Hartman wrote: > > > > > > > This is the start of the stable review cycle for the 6.6.91 release. > > > > > > > There are 113 patches in this series, all will be posted as a response > > > > > > > to this one.  If anyone has any issues with these being applied, please > > > > > > > let me know. > > > > > > > > > > > > > > Responses should be made by Fri, 16 May 2025 12:55:38 +0000. > > > > > > > Anything received after that time might be too late. > > > > > > > > > > > > ld: vmlinux.o: in function `patch_retpoline': > > > > > > alternative.c:(.text+0x3b6f1): undefined reference to `module_alloc' > > > > > > make[2]: *** [scripts/Makefile.vmlinux:37: vmlinux] Error 1 > > > > > > > > > > > > We see this build error in 6.6.91-rc2 tag. > > > > > > > > > > What is odd about your .config?  Have a link to it?  I can't duplicate > > > > > it here on my builds. > > > > > > > > > > > > > So this is a config where CONFIG_MODULES is unset(!=y) -- with that we could reproduce it on defconfig + disabling CONFIG_MODULES as well. > > > > > > > > > > Key is the combination of CONFIG_MODULES=n with CONFIG_MITIGATION_ITS=y. > > > > Ah, this is due to the change in its_alloc() for 6.6.y and 6.1.y by the > > call to module_alloc() instead of execmem_alloc() in the backport of > > 872df34d7c51 ("x86/its: Use dynamic thunks for indirect branches"). > > Sorry for the trouble. I wish I had a test to catch problems like this. The > standard config targets defconfig, allyesconfig, allnoconfig, etc. do not > expose such issues. The only thing that comes close is randconfig. > > CONFIG_MODULES=n is not a common setting, I wonder how people find such > issues? (trying to figure out how to prevent such issues in future). > > > Pawan, any hints on what should be done here instead? > > Since dynamic thunks are not possible without CONFIG_MODULES, one option is > to adjust the already in 6.6.91-rc2 patch 9f35e331144a (x86/its: Fix build > errors when CONFIG_MODULES=n) to also bring the ITS thunk allocation under > CONFIG_MODULES. > > I am not seeing any issue with below build and boot test: > > #!/bin/bash -ex > > ./scripts/config --disable CONFIG_MODULES > ./scripts/config --disable CONFIG_MITIGATION_ITS > # https://github.com/arighi/virtme-ng > vng -b > vng -- lscpu > > # main test > ./scripts/config --disable CONFIG_MODULES > ./scripts/config --enable CONFIG_MITIGATION_ITS > vng -b > vng -- lscpu > > ./scripts/config --enable CONFIG_MODULES > ./scripts/config --disable CONFIG_MITIGATION_ITS > vng -b > vng -- lscpu > > ./scripts/config --enable CONFIG_MODULES > ./scripts/config --enable CONFIG_MITIGATION_ITS > vng -b > vng -- lscpu > > echo "PASS" > > Similar change is required for 6.1 and 5.15 as well. 6.12 is fine because > it uses execmem_alloc(). > > --- 8< --- > From: Pawan Gupta > Subject: [PATCH 6.6] x86/its: Fix build errors when CONFIG_MODULES=n > > From: Eric Biggers > > commit 9f35e33144ae5377d6a8de86dd3bd4d995c6ac65 upstream. > > Fix several build errors when CONFIG_MODULES=n, including the following: > > ../arch/x86/kernel/alternative.c:195:25: error: incomplete definition of type 'struct module' > 195 | for (int i = 0; i < mod->its_num_pages; i++) { > > [ pawan: backport: Bring ITS dynamic thunk code under CONFIG_MODULES ] > > Fixes: 872df34d7c51 ("x86/its: Use dynamic thunks for indirect branches") > Cc: stable@vger.kernel.org > Signed-off-by: Eric Biggers > Acked-by: Dave Hansen > Tested-by: Steven Rostedt (Google) > Reviewed-by: Alexandre Chartre > Signed-off-by: Linus Torvalds > Signed-off-by: Greg Kroah-Hartman Agh! Signed-off-by: Pawan Gupta