public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.12.y v2] iio: light: opt3001: fix deadlock due to concurrent flag access
Date: Sat, 17 May 2025 09:08:05 -0400	[thread overview]
Message-ID: <20250516211535-9c2dbd3945cf02a6@stable.kernel.org> (raw)
In-Reply-To: <20250516184154.5622-1-luca.ceresoli@bootlin.com>

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: f063a28002e3350088b4577c5640882bf4ea17ea

Status in newer kernel trees:
6.14.y | Present (different SHA1: 3950887ff9a9)

Note: The patch differs from the upstream commit:
---
1:  f063a28002e33 ! 1:  99a94f9f0a69a iio: light: opt3001: fix deadlock due to concurrent flag access
    @@ Metadata
      ## Commit message ##
         iio: light: opt3001: fix deadlock due to concurrent flag access
     
    +    [ Upstream commit f063a28002e3350088b4577c5640882bf4ea17ea ]
    +
         The threaded IRQ function in this driver is reading the flag twice: once to
         lock a mutex and once to unlock it. Even though the code setting the flag
         is designed to prevent it, there are subtle cases where the flag could be
    @@ Commit message
         Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
         Link: https://patch.msgid.link/20250321-opt3001-irq-fix-v1-1-6c520d851562@bootlin.com
         Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    +    (cherry picked from commit f063a28002e3350088b4577c5640882bf4ea17ea)
    +    [Fixed conflict while applying on 6.12]
    +    Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
     
      ## drivers/iio/light/opt3001.c ##
     @@ drivers/iio/light/opt3001.c: static irqreturn_t opt3001_irq(int irq, void *_iio)
    + 	struct opt3001 *opt = iio_priv(iio);
      	int ret;
      	bool wake_result_ready_queue = false;
    - 	enum iio_chan_type chan_type = opt->chip_info->chan_type;
     +	bool ok_to_ignore_lock = opt->ok_to_ignore_lock;
      
     -	if (!opt->ok_to_ignore_lock)
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y       |  Success    |  Success   |

      reply	other threads:[~2025-05-17 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 10:05 FAILED: patch "[PATCH] iio: light: opt3001: fix deadlock due to concurrent flag" failed to apply to 6.12-stable tree gregkh
2025-05-15 20:21 ` [PATCH 6.12.y] iio: light: opt3001: fix deadlock due to concurrent flag access Luca Ceresoli
2025-05-16 18:26   ` Sasha Levin
2025-05-16 18:43     ` Luca Ceresoli
2025-05-16 18:41 ` [PATCH 6.12.y v2] " Luca Ceresoli
2025-05-17 13:08   ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250516211535-9c2dbd3945cf02a6@stable.kernel.org \
    --to=sashal@kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox