From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH -stable,6.1 3/3] netfilter: nf_tables: do not defer rule destruction via call_rcu
Date: Tue, 20 May 2025 09:40:28 -0400 [thread overview]
Message-ID: <20250520065817-6b886892979688e9@stable.kernel.org> (raw)
In-Reply-To: <20250519233438.22640-4-pablo@netfilter.org>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: b04df3da1b5c6f6dc7cdccc37941740c078c4043
WARNING: Author mismatch between patch and upstream commit:
Backport author: Pablo Neira Ayuso<pablo@netfilter.org>
Commit author: Florian Westphal<fw@strlen.de>
Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.12.y | Present (different SHA1: 7cf0bd232b56)
6.6.y | Present (different SHA1: 27f0574253f6)
Note: The patch differs from the upstream commit:
---
1: b04df3da1b5c6 ! 1: 5ecb99b42454b netfilter: nf_tables: do not defer rule destruction via call_rcu
@@ Metadata
## Commit message ##
netfilter: nf_tables: do not defer rule destruction via call_rcu
+ commit b04df3da1b5c6f6dc7cdccc37941740c078c4043 upstream.
+
nf_tables_chain_destroy can sleep, it can't be used from call_rcu
callbacks.
@@ Commit message
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
## include/net/netfilter/nf_tables.h ##
-@@ include/net/netfilter/nf_tables.h: struct nft_rule_blob {
- * @name: name of the chain
- * @udlen: user data length
- * @udata: user data in the chain
-- * @rcu_head: rcu head for deferred release
- * @blob_next: rule blob pointer to the next in the chain
- */
- struct nft_chain {
@@ include/net/netfilter/nf_tables.h: struct nft_chain {
char *name;
u16 udlen;
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.6.y | Success | Success |
next prev parent reply other threads:[~2025-05-20 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 23:34 [PATCH -stable,6.1 0/3] Netfilter fixes for -stable Pablo Neira Ayuso
2025-05-19 23:34 ` [PATCH -stable,6.1 1/3] netfilter: nf_tables: pass nft_chain to destroy function, not nft_ctx Pablo Neira Ayuso
2025-05-20 13:42 ` Sasha Levin
2025-05-19 23:34 ` [PATCH -stable,6.1 2/3] netfilter: nf_tables: wait for rcu grace period on net_device removal Pablo Neira Ayuso
2025-05-20 13:36 ` Sasha Levin
2025-05-19 23:34 ` [PATCH -stable,6.1 3/3] netfilter: nf_tables: do not defer rule destruction via call_rcu Pablo Neira Ayuso
2025-05-20 13:40 ` Sasha Levin [this message]
2025-05-20 11:09 ` [PATCH -stable,6.1 0/3] Netfilter fixes for -stable Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520065817-6b886892979688e9@stable.kernel.org \
--to=sashal@kernel.org \
--cc=pablo@netfilter.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox