From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32941922ED; Tue, 20 May 2025 13:58:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747749519; cv=none; b=UMVNUWyRQndD3QAeL4+zlj4PyE2sokYo5w3/u7VxX8lMy51cKwnIbbB7Ataz9ANSHHMS7c9iMKA8A2WLmG1IHrVaAbx4df/kV8eRIPRHsqKxDO+UVxPMDMIey6xYMmQ3g82bXp5ehQPy7xCyye8cXeQHtGNvsgaKF9Bz87KF/HY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747749519; c=relaxed/simple; bh=45WoRwiPapdBousiXcS/EieM5A/swwj2gyef4o9VVkw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F3XAjG1BFJJF0g7DmHSYfP1q3QTuNXIRDDmo7zFIH6fJ6hduMLzlSjtaq+YNdZ+1PUyuwQLXQfAugMNR7WEVo5CgkWunfvP2A8tN3akG/Mom9Z0bCL48qylA43E+xbJcbmjhnKc9vxc3vn7/UeQtmGQwt5s7D2Q8wqRcptBVSX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fIAKH0w7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fIAKH0w7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F647C4CEEF; Tue, 20 May 2025 13:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747749518; bh=45WoRwiPapdBousiXcS/EieM5A/swwj2gyef4o9VVkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fIAKH0w7mQFhQe3lf33ykCo1xELYgiFKBwALj/EY8d59FvDDm/wylKzDxlGp7cqDN FvQYW7XLCpKd0mcEZZs7aPcV3NaAYBwzgyaZu+siG+uUlxlwHk5Yo3S80y9Dm8Bj72 Jxly0Jso7kugBYRI7/XsnCOndUbm/ee/2JoUbrVc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuai Xue , Fenghua Yu , Dave Jiang , Vinod Koul Subject: [PATCH 6.1 71/97] dmaengine: idxd: Add missing cleanups in cleanup internals Date: Tue, 20 May 2025 15:50:36 +0200 Message-ID: <20250520125803.435804090@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520125800.653047540@linuxfoundation.org> References: <20250520125800.653047540@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuai Xue commit 61d651572b6c4fe50c7b39a390760f3a910c7ccf upstream. The idxd_cleanup_internals() function only decreases the reference count of groups, engines, and wqs but is missing the step to release memory resources. To fix this, use the cleanup helper to properly release the memory resources. Fixes: ddf742d4f3f1 ("dmaengine: idxd: Add missing cleanup for early error out in probe call") Cc: stable@vger.kernel.org Signed-off-by: Shuai Xue Reviewed-by: Fenghua Yu Reviewed-by: Dave Jiang Link: https://lore.kernel.org/r/20250404120217.48772-6-xueshuai@linux.alibaba.com Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/dma/idxd/init.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -386,14 +386,9 @@ static int idxd_setup_groups(struct idxd static void idxd_cleanup_internals(struct idxd_device *idxd) { - int i; - - for (i = 0; i < idxd->max_groups; i++) - put_device(group_confdev(idxd->groups[i])); - for (i = 0; i < idxd->max_engines; i++) - put_device(engine_confdev(idxd->engines[i])); - for (i = 0; i < idxd->max_wqs; i++) - put_device(wq_confdev(idxd->wqs[i])); + idxd_clean_groups(idxd); + idxd_clean_engines(idxd); + idxd_clean_wqs(idxd); destroy_workqueue(idxd->wq); }