From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041662459CF; Tue, 20 May 2025 14:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747750476; cv=none; b=CLPmfmmCQEau1Hbtz3p7DKeG18nSQrgHbm9NYsOAiUjhf/SWoeIJlxrFlgwOYazqdxssR0V1qKJkuy/roPOzWOblRazrAVDtDVhEudDoVKDsjf0R7k/2EKpXcsV282jjbj5zNQem/o5NcRqOX66oG1f6XqK+KhP3gwK/2Oo719g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747750476; c=relaxed/simple; bh=bfD6ztLgBytm5hCRC6ed57I6/gzrvSdkbmEfuB6iqxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BCSCAeMiGWcZ/nRPgc97dov2DPmSZ+dfdBSxH4m30+ftTVTCkFQTb+Tnz1yFa/3DVdabnQ2GriUHc5yaQ5STLO25mMfEfJXZJdKv7S1rhb5h1u40OECbBiygBphV3RbhRvjcAa8dLgPyYVcDd0p7Moc9eocV3h/ZPuwR5nCjKLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pUGmxCF6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pUGmxCF6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 737E7C4CEE9; Tue, 20 May 2025 14:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747750475; bh=bfD6ztLgBytm5hCRC6ed57I6/gzrvSdkbmEfuB6iqxw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pUGmxCF630oWExJwSTKLwK/MsCSoozfaYTuYD+9Y2cPl65oL9U8lQNtO0vpdeNL/3 hfvJOJCMQfzWH815b2nj1LSzkqB08UvTSrgQ02sv9tLT/CgmVgie2Be/MM0IseRIS0 xGoDBRoBdz1q0plSmbULcH42sHEtE/OO/OefTPQo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qasim Ijaz , Jiri Kosina , Sasha Levin Subject: [PATCH 6.14 021/145] HID: thrustmaster: fix memory leak in thrustmaster_interrupts() Date: Tue, 20 May 2025 15:49:51 +0200 Message-ID: <20250520125811.388680744@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520125810.535475500@linuxfoundation.org> References: <20250520125810.535475500@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qasim Ijaz [ Upstream commit 09d546303b370113323bfff456c4e8cff8756005 ] In thrustmaster_interrupts(), the allocated send_buf is not freed if the usb_check_int_endpoints() check fails, leading to a memory leak. Fix this by ensuring send_buf is freed before returning in the error path. Fixes: 50420d7c79c3 ("HID: hid-thrustmaster: Fix warning in thrustmaster_probe by adding endpoint check") Signed-off-by: Qasim Ijaz Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-thrustmaster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index 3b81468a1df29..0bf70664c35ee 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -174,6 +174,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev) u8 ep_addr[2] = {b_ep, 0}; if (!usb_check_int_endpoints(usbif, ep_addr)) { + kfree(send_buf); hid_err(hdev, "Unexpected non-int endpoint\n"); return; } -- 2.39.5