From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77B56242D9A; Tue, 20 May 2025 14:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747750814; cv=none; b=Ui4aUEnSa2ULcBYJYSccdc5cHQtUOWTVsaBbHVpSC7d9uxWSnZIW2V2xiHzdaWsjHAI1SkLQaNx0J4OtFKS/3k5wiQDt78zGj9aQ0DTFH+0F69R/XgKda6CUsJfciN/MQTRbByVbQmbkOmwkJS27JltQd1BImXd9swcbGwTumiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747750814; c=relaxed/simple; bh=ob6uIPcwPFe2YQr3ywhLtO6fBLcrHHtEVqYeZdwN6A4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BUzTo37jcyRJfEdFpDYpuvD3ikparj22iSiGLV2N0QBNbX2eaxLzhB/TtF/TRvaTjqkqRIRca2EWyN5YjES3cRLaJ0C5MiCaBk2f+gnRhOev/VU18bmarnLF5CqdIKs5OfJoD/vCUjS3BFJzdPjqIj+VSgWrPgORMQlMElPp1/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tqEMQK2y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tqEMQK2y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C49ACC4CEE9; Tue, 20 May 2025 14:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747750814; bh=ob6uIPcwPFe2YQr3ywhLtO6fBLcrHHtEVqYeZdwN6A4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tqEMQK2y34i5w4rXSKPU7+5tGvnO+gHRDxuyaPYd0c/173tS2saeE9tfSPNrZeivQ 6w0mRcDAv+aSx0Zedev/Alkbh3//zR09U3Pjha0CSXKQBNAqSnx4sX+KAkWrtd9uLf lIqJ78gsWvx0fFT9BKBuSZQd+s5aVtJqZnIB8+xA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuai Xue , Dave Jiang , Fenghua Yu , Vinod Koul Subject: [PATCH 6.14 129/145] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_groups Date: Tue, 20 May 2025 15:51:39 +0200 Message-ID: <20250520125815.597862922@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520125810.535475500@linuxfoundation.org> References: <20250520125810.535475500@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuai Xue commit aa6f4f945b10eac57aed46154ae7d6fada7fccc7 upstream. Memory allocated for groups is not freed if an error occurs during idxd_setup_groups(). To fix it, free the allocated memory in the reverse order of allocation before exiting the function in case of an error. Fixes: defe49f96012 ("dmaengine: idxd: fix group conf_dev lifetime") Cc: stable@vger.kernel.org Signed-off-by: Shuai Xue Reviewed-by: Dave Jiang Reviewed-by: Fenghua Yu Link: https://lore.kernel.org/r/20250404120217.48772-4-xueshuai@linux.alibaba.com Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/dma/idxd/init.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -326,6 +326,7 @@ static int idxd_setup_groups(struct idxd rc = dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id); if (rc < 0) { put_device(conf_dev); + kfree(group); goto err; } @@ -350,7 +351,10 @@ static int idxd_setup_groups(struct idxd while (--i >= 0) { group = idxd->groups[i]; put_device(group_confdev(group)); + kfree(group); } + kfree(idxd->groups); + return rc; }