[PATCH v2] RDMA/irdma: puda: Clear entries after allocation to ensure clean state

[PATCH v2] RDMA/irdma: puda: Clear entries after allocation to ensure clean state

[Wentao Liang]

The irdma_puda_send() calls the irdma_puda_get_next_send_wqe() to get
entries, but does not clear the entries after the function call. A proper
implementation can be found in irdma_uk_send().

Add the irdma_clr_wqes() after irdma_puda_get_next_send_wqe(). Add the
headfile of the irdma_clr_wqes().

Fixes: a3a06db504d3 ("RDMA/irdma: Add privileged UDA queue implementation")
Cc: stable@vger.kernel.org # v5.14
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
v2: Fix code error and remove improper description.

 drivers/infiniband/hw/irdma/puda.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/infiniband/hw/irdma/puda.c b/drivers/infiniband/hw/irdma/puda.c
index 7e3f9bca2c23..f7a826a5bedf 100644
--- a/drivers/infiniband/hw/irdma/puda.c
+++ b/drivers/infiniband/hw/irdma/puda.c
@@ -7,6 +7,7 @@
 #include "protos.h"
 #include "puda.h"
 #include "ws.h"
+#include "user.h"
 
 static void irdma_ieq_receive(struct irdma_sc_vsi *vsi,
 			      struct irdma_puda_buf *buf);
@@ -444,6 +445,8 @@ int irdma_puda_send(struct irdma_sc_qp *qp, struct irdma_puda_send_info *info)
 	if (!wqe)
 		return -ENOMEM;
 
+	irdma_clr_wqes(&qp->qp_uk, wqe_idx);
+
 	qp->qp_uk.sq_wrtrk_array[wqe_idx].wrid = (uintptr_t)info->scratch;
 	/* Third line of WQE descriptor */
 	/* maclen is in words */
-- 
2.42.0.windows.2

Re: [PATCH v2] RDMA/irdma: puda: Clear entries after allocation to ensure clean state

[Leon Romanovsky]

On Sun, May 18, 2025 at 10:49:42PM +0800, Wentao Liang wrote:
> The irdma_puda_send() calls the irdma_puda_get_next_send_wqe() to get
> entries, but does not clear the entries after the function call. A proper
> implementation can be found in irdma_uk_send().
> 
> Add the irdma_clr_wqes() after irdma_puda_get_next_send_wqe(). Add the
> headfile of the irdma_clr_wqes().
> 
> Fixes: a3a06db504d3 ("RDMA/irdma: Add privileged UDA queue implementation")
> Cc: stable@vger.kernel.org # v5.14
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> v2: Fix code error and remove improper description.
> 
>  drivers/infiniband/hw/irdma/puda.c | 3 +++
>  1 file changed, 3 insertions(+)

I need Ack from irdma maintainers.

Thanks