Re: [PATCH 5.10.y/5.15.y] ELF: fix kernel.randomize_va_space double read

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, May 09, 2025 at 02:14:15PM +0800, Feng Liu wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
> 
> [ Upstream commit 2a97388a807b6ab5538aa8f8537b2463c6988bd2 ]
> 
> ELF loader uses "randomize_va_space" twice. It is sysctl and can change
> at any moment, so 2 loads could see 2 different values in theory with
> unpredictable consequences.
> 
> Issue exactly one load for consistent value across one exec.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Link: https://lore.kernel.org/r/3329905c-7eb8-400a-8f0a-d87cff979b5b@p183
> Signed-off-by: Kees Cook <kees@kernel.org>
> Signed-off-by: Feng Liu <Feng.Liu3@windriver.com>
> Signed-off-by: He Zhe <Zhe.He@windriver.com>
> ---
> Verified the build test.

No you did not!  This breaks the build.

This is really really annoying as it breaks the workflow on our side
when you submit code that does not work at all.

Please go and retest all of the outstanding commits that you all have
submitted and fix them up and resend them.  I'm dropping all of the rest
of them from my pending queue as this shows a total lack of testing
happening which implies that I can't trust any of these at all.

And I want you all to prove that you have actually tested the code, not
just this bland "Verified the build test" which is a _very_ low bar,
that is not even happening here at all :(

greg k-h