From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Qingfang Deng <dqfext@gmail.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 5/5] kernfs: dont call d_splice_alias() under kernfs node lock
Date: Wed, 21 May 2025 22:08:12 -0400 [thread overview]
Message-ID: <20250521155203-d448a6286c5d83d9@stable.kernel.org> (raw)
In-Reply-To: <20250521015336.3450911-6-dqfext@gmail.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: df6192f47d2311cf40cd4321cc59863a5853b665
WARNING: Author mismatch between patch and upstream commit:
Backport author: Qingfang Deng<dqfext@gmail.com>
Commit author: Ian Kent<raven@themaw.net>
Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)
6.1.y | Present (exact SHA1)
5.15.y | Present (exact SHA1)
Note: The patch differs from the upstream commit:
---
1: df6192f47d231 ! 1: fde730faa2db3 kernfs: dont call d_splice_alias() under kernfs node lock
@@ Metadata
## Commit message ##
kernfs: dont call d_splice_alias() under kernfs node lock
+ Commit df6192f47d2311cf40cd4321cc59863a5853b665 upstream.
+
The call to d_splice_alias() in kernfs_iop_lookup() doesn't depend on
any kernfs node so there's no reason to hold the kernfs node lock when
calling it.
@@ fs/kernfs/dir.c: static struct dentry *kernfs_iop_lookup(struct inode *dir,
+ return d_splice_alias(inode, dentry);
}
- static int kernfs_iop_mkdir(struct user_namespace *mnt_userns,
+ static int kernfs_iop_mkdir(struct inode *dir, struct dentry *dentry,
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.15.y | Success | Success |
next prev parent reply other threads:[~2025-05-22 2:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 1:53 [PATCH 5.10 0/5] kernfs: backport locking and concurrency improvement Qingfang Deng
2025-05-21 1:53 ` [PATCH 5.10 1/5] kernfs: add a revision to identify directory node changes Qingfang Deng
2025-05-21 4:16 ` Greg Kroah-Hartman
2025-05-22 2:07 ` Sasha Levin
2025-05-21 1:53 ` [PATCH 5.10 2/5] kernfs: use VFS negative dentry caching Qingfang Deng
2025-05-22 2:05 ` Sasha Levin
2025-05-21 1:53 ` [PATCH 5.10 3/5] kernfs: switch kernfs to use an rwsem Qingfang Deng
2025-05-22 2:03 ` Sasha Levin
2025-05-21 1:53 ` [PATCH 5.10 4/5] kernfs: use i_lock to protect concurrent inode updates Qingfang Deng
2025-05-22 2:07 ` Sasha Levin
2025-05-21 1:53 ` [PATCH 5.10 5/5] kernfs: dont call d_splice_alias() under kernfs node lock Qingfang Deng
2025-05-22 2:08 ` Sasha Levin [this message]
2025-05-21 4:15 ` [PATCH 5.10 0/5] kernfs: backport locking and concurrency improvement Greg Kroah-Hartman
2025-05-21 5:35 ` Ian Kent
2025-05-21 6:09 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521155203-d448a6286c5d83d9@stable.kernel.org \
--to=sashal@kernel.org \
--cc=dqfext@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox