Re: [PATCH v6.1 05/27] af_unix: Replace BUG_ON() with WARN_ON_ONCE().

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: d0f6dc26346863e1f4a23117f5468614e54df064

WARNING: Author mismatch between patch and upstream commit:
Backport author: Lee Jones<lee@kernel.org>
Commit author: Kuniyuki Iwashima<kuniyu@amazon.com>

Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Not found

Note: The patch differs from the upstream commit:
---
1:  d0f6dc2634686 ! 1:  8d734ba6e6dbe af_unix: Replace BUG_ON() with WARN_ON_ONCE().
    @@ Metadata
      ## Commit message ##
         af_unix: Replace BUG_ON() with WARN_ON_ONCE().
     
    +    [ Upstream commit d0f6dc26346863e1f4a23117f5468614e54df064 ]
    +
         This is a prep patch for the last patch in this series so that
         checkpatch will not warn about BUG_ON().
     
    @@ Commit message
         Acked-by: Jens Axboe <axboe@kernel.dk>
         Link: https://lore.kernel.org/r/20240129190435.57228-2-kuniyu@amazon.com
         Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    +    (cherry picked from commit d0f6dc26346863e1f4a23117f5468614e54df064)
    +    Signed-off-by: Lee Jones <lee@kernel.org>
     
      ## net/unix/garbage.c ##
     @@ net/unix/garbage.c: static void scan_children(struct sock *x, void (*func)(struct unix_sock *),
    @@ net/unix/garbage.c: static void scan_children(struct sock *x, void (*func)(struc
      		spin_unlock(&x->sk_receive_queue.lock);
     @@ net/unix/garbage.c: static void __unix_gc(struct work_struct *work)
      
    - 		total_refs = file_count(u->sk.sk_socket->file);
    + 		total_refs = file_count(sk->sk_socket->file);
      
     -		BUG_ON(!u->inflight);
     -		BUG_ON(total_refs < u->inflight);
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.6.y        |  Success    |  Success   |