From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8691DE2D6 for ; Sat, 24 May 2025 15:49:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748101782; cv=none; b=km20N4lnHhf7lMfPc8M2IFOfc3ZhzBiMXwfvWUPRNl9u0vV8RrjtfnHoulX+bKkfewhK2A1pwCMu96FGYFTN3SBZjMuW4GMBVBjhDWuvcCUt+Sy2nSvdKFFHaoACLz8nUrVNAXY4D80UPP3F4q48qvv/BKcgxYbdWfVokccNkaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748101782; c=relaxed/simple; bh=IfxC2RW9V/TqOX8FkpPYvdeezXYBSWUspQ2CySKbWMc=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=Z6TTFzc9cGAYsSgaTgaq5VzFuEYpKjyXSJSjEZaoN8ejFEXIrjH8kLs/wOg1qsCsMFnx582Jm49B928vv5Abtaa1LErtuAImcMQoap6nDs8tZx6Ns8H2Vj6MhKZ80qhB5mjpjfHNJZg4P9x6Vm8MZUH/8XK+SAMQ1DdX3rNdVxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AtG0xm8Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AtG0xm8Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BE13C4CEE4; Sat, 24 May 2025 15:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748101782; bh=IfxC2RW9V/TqOX8FkpPYvdeezXYBSWUspQ2CySKbWMc=; h=Subject:To:Cc:From:Date:From; b=AtG0xm8ZUXmF3sepZ1Q5zv4aoexvZW+UxrjbuFK1dBKfFVpFCnFXMIaZHbk50Dr3k ey8kH4R2EnB+ncVT4ownmAjixeF5JGgauM3ChiQPWgGov0QsfyJ7IlkGmLiWquaYxo zFeJmDohLr0IJIvbh5JRse1iNvVzTXhQ7/7j3Ho0= Subject: FAILED: patch "[PATCH] vmxnet3: update MTU after device quiesce" failed to apply to 5.10-stable tree To: ronak.doshi@broadcom.com,guolin.yang@broadcom.com,kuba@kernel.org Cc: From: Date: Sat, 24 May 2025 17:49:26 +0200 Message-ID: <2025052426-pleading-slip-af7c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 43f0999af011fba646e015f0bb08b6c3002a0170 # git commit -s git send-email --to '' --in-reply-to '2025052426-pleading-slip-af7c@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 43f0999af011fba646e015f0bb08b6c3002a0170 Mon Sep 17 00:00:00 2001 From: Ronak Doshi Date: Thu, 15 May 2025 19:04:56 +0000 Subject: [PATCH] vmxnet3: update MTU after device quiesce Currently, when device mtu is updated, vmxnet3 updates netdev mtu, quiesces the device and then reactivates it for the ESXi to know about the new mtu. So, technically the OS stack can start using the new mtu before ESXi knows about the new mtu. This can lead to issues for TSO packets which use mss as per the new mtu configured. This patch fixes this issue by moving the mtu write after device quiesce. Cc: stable@vger.kernel.org Fixes: d1a890fa37f2 ("net: VMware virtual Ethernet NIC driver: vmxnet3") Signed-off-by: Ronak Doshi Acked-by: Guolin Yang Changes v1-> v2: Moved MTU write after destroy of rx rings Link: https://patch.msgid.link/20250515190457.8597-1-ronak.doshi@broadcom.com Signed-off-by: Jakub Kicinski diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 3df6aabc7e33..c676979c7ab9 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -3607,8 +3607,6 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu) struct vmxnet3_adapter *adapter = netdev_priv(netdev); int err = 0; - WRITE_ONCE(netdev->mtu, new_mtu); - /* * Reset_work may be in the middle of resetting the device, wait for its * completion. @@ -3622,6 +3620,7 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu) /* we need to re-create the rx queue based on the new mtu */ vmxnet3_rq_destroy_all(adapter); + WRITE_ONCE(netdev->mtu, new_mtu); vmxnet3_adjust_rx_ring_size(adapter); err = vmxnet3_rq_create_all(adapter); if (err) { @@ -3638,6 +3637,8 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu) "Closing it\n", err); goto out; } + } else { + WRITE_ONCE(netdev->mtu, new_mtu); } out: