From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78386154C15; Tue, 27 May 2025 17:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365266; cv=none; b=Rz/lyQx+BndfPWOuXauozZ4E1Ywfs/7wIPjKN1acm/W/DgWAPe10TSxS94xOS1t7+6Wm4OyRDCOs2gOuDYOOsbqiTXGyV5Pz6w7adg/o49fo/5PVt/j8t2wXdKZ86QDVzeKnh2csynQnattz7z/x3gKRggfLwp/VGKUEtXlS8kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365266; c=relaxed/simple; bh=JcSQScUB9W4/43h8bDvP7q1q5gqK2KS+sjhqgJdylTA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FEAOWWI+efzi0DWooVoq+ORuuchMAGqtIv8VdxcX3j2BzuSqu05uEVA8YBQiUYg8LdmXZJcJBjdM5ilTQNlaEB6sv7RvIoBSfIT97mrNTIPu5QU8LeF4io6oX/lYMoDGwhs6mBBK1lDB0M9+LAIdh1TmyXZdezGIOgIaWLFwMlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WjgVrXc7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WjgVrXc7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09AD2C4CEE9; Tue, 27 May 2025 17:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748365266; bh=JcSQScUB9W4/43h8bDvP7q1q5gqK2KS+sjhqgJdylTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WjgVrXc70GKMu4bIX91VNMyxBUohN8ODbxapnv04zaY4y5pv5PRShC2zB7pfwy9ng hNxLV7QVusTOdbXz2loKYBMDnj73bPXikuz9RQco32d7DTn6YDFkpalMeV54POZ54z UbGfDw9N2bTf3CFsWjlxSRRxav7Ob/PAAQvbGgNg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ping-Ke Shih , Sasha Levin Subject: [PATCH 6.12 321/626] wifi: rtw89: fw: propagate error code from rtw89_h2c_tx() Date: Tue, 27 May 2025 18:23:34 +0200 Message-ID: <20250527162458.073289274@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250527162445.028718347@linuxfoundation.org> References: <20250527162445.028718347@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ping-Ke Shih [ Upstream commit 56e1acaa0f80620b8e2c3410db35b4b975782b0a ] The error code should be propagated to callers during downloading firmware header and body. Remove unnecessary assignment of -1. Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20250217064308.43559-4-pkshih@realtek.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtw89/fw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c index 620e076d1b597..9d26502a2885a 100644 --- a/drivers/net/wireless/realtek/rtw89/fw.c +++ b/drivers/net/wireless/realtek/rtw89/fw.c @@ -1234,7 +1234,6 @@ static int __rtw89_fw_download_hdr(struct rtw89_dev *rtwdev, ret = rtw89_h2c_tx(rtwdev, skb, false); if (ret) { rtw89_err(rtwdev, "failed to send h2c\n"); - ret = -1; goto fail; } @@ -1311,7 +1310,6 @@ static int __rtw89_fw_download_main(struct rtw89_dev *rtwdev, ret = rtw89_h2c_tx(rtwdev, skb, true); if (ret) { rtw89_err(rtwdev, "failed to send h2c\n"); - ret = -1; goto fail; } -- 2.39.5