From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4102C139579; Tue, 27 May 2025 17:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365849; cv=none; b=AsTWq6fpvOYGi0D4B2iTzDZXdTQjD9QxMsb37ow8IBbcBaMdjOCC8+r+Q+vWnnemiB31XZ2ksZ3YU482aCGrioDWVvmWJcvujWIIi8x1HU+U4HDFCMIw/OssV8qwDa6HLkGpATwTq1sXJ77yKFBPQrmRd3tdoE/wP23pZPIYJB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365849; c=relaxed/simple; bh=mXXVSRvIhkQxYNxU6g0+qNAThg0Se6NAG2CGOTfMb7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l/KXfFJo4vNGIs+Imk+5uE5gTzpn+IP7VWbteRRFJUfi9Aw5YEuVeBJf1BOdbYh1e/2+bhSqMOVvpMv6UpjAc3ZyK7SDr731Kg02LB+KrHMn0VIU6VKJ1GrUkjfzt1AyhxP9PXLEygDlzuBUuWFFxPT4hor2ZngRaO4XT243uL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gXGCxC8z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gXGCxC8z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2818C4CEEB; Tue, 27 May 2025 17:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748365849; bh=mXXVSRvIhkQxYNxU6g0+qNAThg0Se6NAG2CGOTfMb7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gXGCxC8zWZZ4M6EtJQArRd/dq6u3k93tsW7UAN4k9uUkt8ThNNsnSZyd26JMdJkur 1zoArDVqxqe/LTIs6nd7LOfa0CwMPYYdCFrbDl4eeJR5KH67QW/X1UoiRA6aQD6gID 0cl3bnJztX0BkZPhbdcHz3+aKUmQuJhfnIZJ9E2Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Martin Blumenstingl , Neil Armstrong , Linus Walleij , Sasha Levin Subject: [PATCH 6.12 507/626] pinctrl: meson: define the pull up/down resistor value as 60 kOhm Date: Tue, 27 May 2025 18:26:40 +0200 Message-ID: <20250527162505.563979934@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250527162445.028718347@linuxfoundation.org> References: <20250527162445.028718347@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Martin Blumenstingl [ Upstream commit e56088a13708757da68ad035269d69b93ac8c389 ] The public datasheets of the following Amlogic SoCs describe a typical resistor value for the built-in pull up/down resistor: - Meson8/8b/8m2: not documented - GXBB (S905): 60 kOhm - GXL (S905X): 60 kOhm - GXM (S912): 60 kOhm - G12B (S922X): 60 kOhm - SM1 (S905D3): 60 kOhm The public G12B and SM1 datasheets additionally state min and max values: - min value: 50 kOhm for both, pull-up and pull-down - max value for the pull-up: 70 kOhm - max value for the pull-down: 130 kOhm Use 60 kOhm in the pinctrl-meson driver as well so it's shown in the debugfs output. It may not be accurate for Meson8/8b/8m2 but in reality 60 kOhm is closer to the actual value than 1 Ohm. Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/20250329190132.855196-1-martin.blumenstingl@googlemail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 253a0cc57e396..e5a32a0532eee 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -487,7 +487,7 @@ static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin, case PIN_CONFIG_BIAS_PULL_DOWN: case PIN_CONFIG_BIAS_PULL_UP: if (meson_pinconf_get_pull(pc, pin) == param) - arg = 1; + arg = 60000; else return -EINVAL; break; -- 2.39.5