From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Talhah Peerbhai <talhah.peerbhai@gmail.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
mario.limonciello@amd.com, venkataprasad.potturu@amd.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH AUTOSEL 6.6 48/66] ASoC: amd: yc: Add quirk for Lenovo Yoga Pro 7 14ASP9
Date: Sun, 1 Jun 2025 19:37:25 -0400 [thread overview]
Message-ID: <20250601233744.3514795-48-sashal@kernel.org> (raw)
In-Reply-To: <20250601233744.3514795-1-sashal@kernel.org>
From: Talhah Peerbhai <talhah.peerbhai@gmail.com>
[ Upstream commit a28206060dc5848a1a2a15b7f6ac6223d869084d ]
Similar to many other Lenovo models with AMD chips, the Lenovo
Yoga Pro 7 14ASP9 (product name 83HN) requires a specific quirk
to ensure internal mic detection. This patch adds a quirk fixing this.
Signed-off-by: Talhah Peerbhai <talhah.peerbhai@gmail.com>
Link: https://patch.msgid.link/20250515222741.144616-1-talhah.peerbhai@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Based on my analysis of the commit and comparison with the similar
historical commits, here is my assessment: **YES** This commit should be
backported to stable kernel trees for the following reasons: ## Code
Analysis **1. Nature of the Change:** The commit adds a single quirk
entry for the Lenovo Yoga Pro 7 14ASP9 (product name "83HN") to the
`yc_acp_quirk_table[]` array in `sound/soc/amd/yc/acp6x-mach.c`. The
change is minimal and contained: ```c + { + .driver_data = &acp6x_card,
+ .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), +
DMI_MATCH(DMI_PRODUCT_NAME, "83HN"), + } + }, ``` **2. Meets Stable Tree
Criteria:** - **Device ID Addition**: This is explicitly mentioned in
the stable kernel rules as acceptable - "It must either fix a real bug
that bothers people or just add a device ID" - **Under 100 lines**: The
change is only 7 lines with context - **Obviously correct**: The pattern
matches exactly what's used for dozens of other Lenovo models - **Fixes
real user issue**: Internal microphone non-functionality is a clear
hardware regression/bug that affects users **3. Historical Precedent:**
All 5 similar commits provided as examples received "Backport Status:
YES". They all follow the exact same pattern: - Similar commit subjects
mentioning specific Lenovo models - Identical code structure adding DMI
quirk entries - Same commit messages describing microphone functionality
fixes - Several explicitly included `Cc: stable@vger.kernel.org` tags
**4. Risk Assessment:** - **Minimal regression risk**: Adding a quirk
entry cannot break existing functionality - **Contained change**: Only
affects the specific Lenovo model 83HN - **Well-established pattern**:
This quirk mechanism is proven stable across dozens of similar entries
**5. User Impact:** The commit message clearly states this fixes
internal microphone detection on a specific laptop model. Non-functional
audio hardware represents a significant user-facing issue that stable
trees are meant to address. **6. Code Quality:** The change also
includes a minor whitespace fix (replacing spaces with tab for
consistency), showing attention to code quality without introducing
functional changes. This commit perfectly matches the stable tree
criteria: it's a small, safe device ID addition that fixes a real user-
affecting hardware issue with minimal risk of regression.
sound/soc/amd/yc/acp6x-mach.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 622df58a96942..9fdee74c28df2 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -311,6 +311,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "83AS"),
}
},
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "83HN"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
@@ -360,7 +367,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
}
},
- {
+ {
.driver_data = &acp6x_card,
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
--
2.39.5
next prev parent reply other threads:[~2025-06-01 23:39 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-01 23:36 [PATCH AUTOSEL 6.6 01/66] drm/amdgpu/gfx6: fix CSIB handling Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 02/66] media: imx-jpeg: Check decoding is ongoing for motion-jpeg Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 03/66] drm/dp: add option to disable zero sized address only transactions Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 04/66] sunrpc: update nextcheck time when adding new cache entries Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 05/66] drm/amd/display: DCN32 null data check Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 06/66] drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of calling disable_irq() Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 07/66] workqueue: Fix race condition in wq->stats incrementation Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 08/66] exfat: fix double free in delayed_free Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 09/66] arm64/cpuinfo: only show one cpu's info in c_show() Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 10/66] drm/bridge: anx7625: change the gpiod_set_value API Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 11/66] drm/amdgpu/gfx11: fix CSIB handling Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 12/66] media: i2c: imx334: Enable runtime PM before sub-device registration Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 13/66] drm/msm/hdmi: add runtime PM calls to DDC transfer function Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 14/66] media: uapi: v4l: Fix V4L2_TYPE_IS_OUTPUT condition Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 15/66] drm/amd/display: Add NULL pointer checks in dm_force_atomic_commit() Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 16/66] media: verisilicon: Enable wide 4K in AV1 decoder Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 17/66] drm/amd/display: Skip to enable dsc if it has been off Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 18/66] drm/msm/a6xx: Increase HFI response timeout Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 19/66] drm/amd/display: Do Not Consider DSC if Valid Config Not Found Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 20/66] media: i2c: imx334: Fix runtime PM handling in remove function Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 21/66] drm/amdgpu/gfx10: fix CSIB handling Sasha Levin
2025-06-01 23:36 ` [PATCH AUTOSEL 6.6 22/66] drm: panel-orientation-quirks: Add ZOTAC Gaming Zone Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 23/66] media: ccs-pll: Better validate VT PLL branch Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 24/66] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE condition Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 25/66] drm/amdgpu/gfx7: fix CSIB handling Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 26/66] ext4: ext4: unify EXT4_EX_NOCACHE|NOFAIL flags in ext4_ext_remove_space() Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 27/66] jfs: fix array-index-out-of-bounds read in add_missing_indices Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 28/66] media: ti: cal: Fix wrong goto on error path Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 29/66] media: rkvdec: h264: Use bytesperline and buffer height as virstride Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 30/66] media: rkvdec: Initialize the m2m context before the controls Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 31/66] sunrpc: fix race in cache cleanup causing stale nextcheck time Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 32/66] ext4: prevent stale extent cache entries caused by concurrent get es_cache Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 33/66] drm/amdgpu/gfx8: fix CSIB handling Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 34/66] drm/amdgpu/gfx9: " Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 35/66] jfs: Fix null-ptr-deref in jfs_ioc_trim Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 36/66] drm/amd/display: Correct prefetch calculation Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 37/66] drm/msm/dpu: don't select single flush for active CTL blocks Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 38/66] drm/amdkfd: Set SDMA_RLCx_IB_CNTL/SWITCH_INSIDE_IB Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 39/66] media: tc358743: ignore video while HPD is low Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 40/66] media: platform: exynos4-is: Add hardware sync wait to fimc_is_hw_change_mode() Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 41/66] media: i2c: imx334: update mode_3840x2160_regs array Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 42/66] nios2: force update_mmu_cache on spurious tlb-permission--related pagefaults Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 43/66] media: rcar-vin: Fix stride setting for RAW8 formats Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 44/66] media: qcom: venus: Fix uninitialized variable warning Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 45/66] ACPI: bus: Bail out if acpi_kobj registration fails Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 46/66] pmdomain: ti: Fix STANDBY handling of PER power domain Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 47/66] PM: runtime: fix denying of auto suspend in pm_suspend_timer_fn() Sasha Levin
2025-06-01 23:37 ` Sasha Levin [this message]
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 49/66] thermal/drivers/qcom/tsens: Update conditions to strictly evaluate for IP v2+ Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 50/66] clocksource/drivers/timer-tegra186: Fix watchdog self-pinging Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 51/66] gpio: pxa: Make irq_chip immutable Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 52/66] gpio: grgpio: " Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 53/66] gpio: xgene-sb: " Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 54/66] genirq: Retain disable depth for managed interrupts across CPU hotplug Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 55/66] mmc: sdhci-esdhc-imx: Save tuning value when card stays powered in suspend Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 56/66] mmc: Add quirk to disable DDR50 tuning Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 57/66] clocksource: Fix the CPUs' choice in the watchdog per CPU verification Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 58/66] ACPICA: Avoid sequence overread in call to strncmp() Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 59/66] ACPICA: utilities: Fix overflow check in vsnprintf() Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 60/66] ACPI: EC: Add device to acpi_ec_no_wakeup[] qurik list Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 61/66] ALSA: seq: Remove unused snd_seq_queue_client_leave_cells Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 62/66] cpufreq: Force sync policy boost with global boost on sysfs update Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 63/66] power: supply: bq27xxx: Retrieve again when busy Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 64/66] tools/nolibc: use intmax definitions from compiler Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 65/66] gpio: ds4520: don't check the 'ngpios' property in the driver Sasha Levin
2025-06-01 23:37 ` [PATCH AUTOSEL 6.6 66/66] ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250601233744.3514795-48-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=patches@lists.linux.dev \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=talhah.peerbhai@gmail.com \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox