From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4705222A1FA; Mon, 2 Jun 2025 14:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748872957; cv=none; b=jMMWXxBAiHTP8mpOU68gtb/ThI4aAQhMBgFWio11pQVt+zvLwcXcQjZlr6LHS1IfSMq9ThRneTdfMJTKB89JBJhRrvylDl/aaUVhk72Hl8WAm4UhWzR2/82BZYG6s6YJscPvrZRDA8qBRQuX8GwhV2Vns/uR3jCNJS1GY6jHyys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748872957; c=relaxed/simple; bh=vPXc9xDxvjYXDkaZRGacFv53luI/X1pz+8qIq1Mz2Ck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+yqTEhRTAzAxnjBwGrb7E4y6DLsqShAuXXcoSDabrcU8AcRES6VY/bWwEF2pagP4s3bquLlyoA0JzVUNWhMrYWUG8U8XWQW1F/FWeN2am8GZ+vd+eJ5zQXC2SY5npsKZr5OKDoVkanq4C0HqrdM6zanpEGmm5hCTQPpIGJDTic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=q7aFsHOB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="q7aFsHOB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92BF7C4CEEB; Mon, 2 Jun 2025 14:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748872957; bh=vPXc9xDxvjYXDkaZRGacFv53luI/X1pz+8qIq1Mz2Ck=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q7aFsHOBO8Ary/OiNC40fbfjy+IBmb72LgzY7dSQnqsIYE0XWbY0+eEBbxsSv/bzn akzzRuf1uXVr0pSDeWfuVYuHwiSvpJJavwIou2WVZzvEZ9Rcc04Jgm0z8+QEZquSJf 4Tr5AzraT+F6EiRavUaxcZw67EHcT+1B35/U/+YI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Purva Yeshi , Stefano Garzarella , Jarkko Sakkinen , Sasha Levin Subject: [PATCH 6.12 49/55] char: tpm: tpm-buf: Add sanity check fallback in read helpers Date: Mon, 2 Jun 2025 15:48:06 +0200 Message-ID: <20250602134240.207828274@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134238.271281478@linuxfoundation.org> References: <20250602134238.271281478@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Purva Yeshi [ Upstream commit 32d495b384a2db7d23c2295e03e6b6edb1c0db8d ] Fix Smatch-detected issue: drivers/char/tpm/tpm-buf.c:208 tpm_buf_read_u8() error: uninitialized symbol 'value'. drivers/char/tpm/tpm-buf.c:225 tpm_buf_read_u16() error: uninitialized symbol 'value'. drivers/char/tpm/tpm-buf.c:242 tpm_buf_read_u32() error: uninitialized symbol 'value'. Zero-initialize the return values in tpm_buf_read_u8(), tpm_buf_read_u16(), and tpm_buf_read_u32() to guard against uninitialized data in case of a boundary overflow. Add defensive initialization ensures the return values are always defined, preventing undefined behavior if the unexpected happens. Signed-off-by: Purva Yeshi Reviewed-by: Stefano Garzarella Reviewed-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen Signed-off-by: Sasha Levin --- drivers/char/tpm/tpm-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm-buf.c b/drivers/char/tpm/tpm-buf.c index e49a19fea3bdf..dc882fc9fa9ef 100644 --- a/drivers/char/tpm/tpm-buf.c +++ b/drivers/char/tpm/tpm-buf.c @@ -201,7 +201,7 @@ static void tpm_buf_read(struct tpm_buf *buf, off_t *offset, size_t count, void */ u8 tpm_buf_read_u8(struct tpm_buf *buf, off_t *offset) { - u8 value; + u8 value = 0; tpm_buf_read(buf, offset, sizeof(value), &value); @@ -218,7 +218,7 @@ EXPORT_SYMBOL_GPL(tpm_buf_read_u8); */ u16 tpm_buf_read_u16(struct tpm_buf *buf, off_t *offset) { - u16 value; + u16 value = 0; tpm_buf_read(buf, offset, sizeof(value), &value); @@ -235,7 +235,7 @@ EXPORT_SYMBOL_GPL(tpm_buf_read_u16); */ u32 tpm_buf_read_u32(struct tpm_buf *buf, off_t *offset) { - u32 value; + u32 value = 0; tpm_buf_read(buf, offset, sizeof(value), &value); -- 2.39.5