From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D1D1C5D72; Mon, 2 Jun 2025 13:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748872749; cv=none; b=cN2RUsJ2WRILZU1N2+LaXwpZ9R5mZgaLl90MvUeF3/WibmwxqB4v4sY/ghgAB3r8cdxlfTuZLuc+mcqUmN0efUW2aCn0ZxNGAphb6V05qknDdLSjhEFFUh2LjlBH7T0LZ3Bb0P2hp6VeRTcoznYveoSY4s2R2MU3AvTZSInX2Bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748872749; c=relaxed/simple; bh=wgLxbBNA0QMDkXAo/PJEZmo3HSDKAR7AquiC9bY9b2o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CD6y47gNmIuEaWlkGhId/Qlm8cOl6vPcMq7i/m/R6+vcJPQZSTYqfIBrPJAd2HdN805zkeG1RIgUNUTIfbHx7SUZ9ahVa9ZgwBF6HkO5e+G75fEKBKJZ4c++YWiDIPkkKmWtUHjqfk4bWuiL4NQ8Qa9EUDf9xdCnMMasCKMRa3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=e3iObxWv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="e3iObxWv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 757E2C4CEEB; Mon, 2 Jun 2025 13:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748872748; bh=wgLxbBNA0QMDkXAo/PJEZmo3HSDKAR7AquiC9bY9b2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e3iObxWv0v3lguRJAczd0vJS+OEPeIOYqX/yJtxKErpZqn7ceBOdAgncQwa4k6+14 2KmvQgrVzL3XI1wat8OyuqXKni/6afzq+Ny24DtKXY+TmDbv4XCDvGhIZ/3nJSlCe2 wQUrOy6HUQSH5At9EKP+dVpH9PVnRrFydcxEtEkM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Markus Burri , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.14 56/73] gpio: virtuser: fix potential out-of-bound write Date: Mon, 2 Jun 2025 15:47:42 +0200 Message-ID: <20250602134243.901814090@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134241.673490006@linuxfoundation.org> References: <20250602134241.673490006@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Markus Burri [ Upstream commit 7118be7c6072f40391923543fdd1563b8d56377c ] If the caller wrote more characters, count is truncated to the max available space in "simple_write_to_buffer". Check that the input size does not exceed the buffer size. Write a zero termination afterwards. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202505091754.285hHbr2-lkp@intel.com/ Signed-off-by: Markus Burri Link: https://lore.kernel.org/r/20250509150459.115489-1-markus.burri@mt.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-virtuser.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-virtuser.c b/drivers/gpio/gpio-virtuser.c index e89f299f21400..dcecb7a259117 100644 --- a/drivers/gpio/gpio-virtuser.c +++ b/drivers/gpio/gpio-virtuser.c @@ -400,10 +400,15 @@ static ssize_t gpio_virtuser_direction_do_write(struct file *file, char buf[32], *trimmed; int ret, dir, val = 0; - ret = simple_write_to_buffer(buf, sizeof(buf), ppos, user_buf, count); + if (count >= sizeof(buf)) + return -EINVAL; + + ret = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, user_buf, count); if (ret < 0) return ret; + buf[ret] = '\0'; + trimmed = strim(buf); if (strcmp(trimmed, "input") == 0) { @@ -622,12 +627,15 @@ static ssize_t gpio_virtuser_consumer_write(struct file *file, char buf[GPIO_VIRTUSER_NAME_BUF_LEN + 2]; int ret; + if (count >= sizeof(buf)) + return -EINVAL; + ret = simple_write_to_buffer(buf, GPIO_VIRTUSER_NAME_BUF_LEN, ppos, user_buf, count); if (ret < 0) return ret; - buf[strlen(buf) - 1] = '\0'; + buf[ret] = '\0'; ret = gpiod_set_consumer_name(data->ad.desc, buf); if (ret) -- 2.39.5