From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D642F22DF84; Mon, 2 Jun 2025 14:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748874492; cv=none; b=QI12IuEoeRlSbIAjAJrBXB9lygr9SjW2uzZqa6dxiFK2hJR031frh6I4QRWwYojJ2O0vytIQC9HE2GV9hXXcCPHJWoxQ4Jnfad++6LPhd8ilzXJTQ9HOqV7wz0sqXLo30DrmA0iMcn+fPIHyGfa+Phe2p/h6TOOPgVTVE/9Mrac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748874492; c=relaxed/simple; bh=ACWqTkPzHD+/7huJXUfYvvaZrlroRs7HUzyaRf3iZ8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hxrHSrsZdekbVVnU+nst2sBwqOmV0BwduW5zZ9LuObYAEy+DLkBRaCt5g9ZC/ivx+e6rgdb97GkCyR07GkBK1+V+5Vq/r1H9VEn6G3fs1DM6npwVyG8NQZ3A/0N7YER1oxj3fDsiptxRWas2gyLloZFtXbOVz/Wyw6PgTh5iG2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zFKcnmZV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zFKcnmZV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65FABC4CEEB; Mon, 2 Jun 2025 14:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748874492; bh=ACWqTkPzHD+/7huJXUfYvvaZrlroRs7HUzyaRf3iZ8Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zFKcnmZVUXatbPSKPsoz1b1BKUQo5iDIRVHOM7Ti6aRFuokq9oBqktRfz28B6HyL5 /h30e9XxpOSpsn3dEvNsgEmL0jbPNNNPa0+6v91KmkgC+gjVSeXeVUt/QQhg2Od/lz u4ru28AUadLWqeS/iOidVN7gMyh06KSF3naCibkI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maor Gottlieb , Mark Bloch , Michal Swiatkowski , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 010/204] net/mlx5: E-Switch, Initialize MAC Address for Default GID Date: Mon, 2 Jun 2025 15:45:43 +0200 Message-ID: <20250602134255.881995749@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134255.449974357@linuxfoundation.org> References: <20250602134255.449974357@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maor Gottlieb [ Upstream commit 5d1a04f347e6cbf5ffe74da409a5d71fbe8c5f19 ] Initialize the source MAC address when creating the default GID entry. Since this entry is used only for loopback traffic, it only needs to be a unicast address. A zeroed-out MAC address is sufficient for this purpose. Without this fix, random bits would be assigned as the source address. If these bits formed a multicast address, the firmware would return an error, preventing the user from switching to switchdev mode: Error: mlx5_core: Failed setting eswitch to offloads. kernel answers: Invalid argument Fixes: 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic") Signed-off-by: Maor Gottlieb Signed-off-by: Mark Bloch Reviewed-by: Michal Swiatkowski Link: https://patch.msgid.link/20250423083611.324567-3-mbloch@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c index 2389239acadc9..945d90844f0cb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c @@ -130,8 +130,8 @@ static void mlx5_rdma_make_default_gid(struct mlx5_core_dev *dev, union ib_gid * static int mlx5_rdma_add_roce_addr(struct mlx5_core_dev *dev) { + u8 mac[ETH_ALEN] = {}; union ib_gid gid; - u8 mac[ETH_ALEN]; mlx5_rdma_make_default_gid(dev, &gid); return mlx5_core_roce_gid_set(dev, 0, -- 2.39.5