From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA2E41EDA02; Mon, 2 Jun 2025 14:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748874773; cv=none; b=d3AwvwDrER1t3oflFc7TyK4M169Bbd3UoUPfxE0TEt4qCHIQJfmqp+b5tPVQQlWipwkncwDIiBWGV/G9d+fn/ScP2ZkVoUpGmFjRIAQzyEuscZpaQTWSZ1pvm7JaoyCS3bO6yutvFP2vwCfzP541cELknA317TnGW0rSMSsePyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748874773; c=relaxed/simple; bh=jt9pgQNboN/pCAr34RA247rTGJP23ICk7jFPNzt7LJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ioOs0P6/0HynroF8jCQfM9gxMP6VvPrqSBQJhTr2s+uyo/ZsLk+xcGEtace19RRWhkYFjIPn65xGLECMK/KIfUV6rLG5oySAxlPKcyMCNQ/bWGF8+Cz/e/Ej/eG6E9Oi1FImVQ2qh7AeTqZ1eBxRMuCe8tY4UlizQmqTugqHKsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y+MsLfe9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y+MsLfe9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAE24C4CEEB; Mon, 2 Jun 2025 14:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748874773; bh=jt9pgQNboN/pCAr34RA247rTGJP23ICk7jFPNzt7LJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y+MsLfe9Q5XIglYVfqjLWUhhLjWOh4tlFZhr3whkMQ/YKuShT0F8z32tEdr7D3wL1 o8fLWSt0VDS8tcHiBGkvBPJ015YIzsXI/PFq2tGK01rPyXXgJvCXDtXkOu5xNoCq/o hnD5+UCCZsumwzlWitZbTe0ZdaMh+VBuWhyx2eV8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hangbin Liu , Nikolay Aleksandrov , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 131/204] bonding: report duplicate MAC address in all situations Date: Mon, 2 Jun 2025 15:47:44 +0200 Message-ID: <20250602134300.797354937@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134255.449974357@linuxfoundation.org> References: <20250602134255.449974357@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hangbin Liu [ Upstream commit 28d68d396a1cd21591e8c6d74afbde33a7ea107e ] Normally, a bond uses the MAC address of the first added slave as the bond’s MAC address. And the bond will set active slave’s MAC address to bond’s address if fail_over_mac is set to none (0) or follow (2). When the first slave is removed, the bond will still use the removed slave’s MAC address, which can lead to a duplicate MAC address and potentially cause issues with the switch. To avoid confusion, let's warn the user in all situations, including when fail_over_mac is set to 2 or not in active-backup mode. Signed-off-by: Hangbin Liu Reviewed-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20250225033914.18617-1-liuhangbin@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 89797b2575733..3b235a269c1b8 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1954,7 +1954,7 @@ static int __bond_release_one(struct net_device *bond_dev, RCU_INIT_POINTER(bond->current_arp_slave, NULL); - if (!all && (!bond->params.fail_over_mac || + if (!all && (bond->params.fail_over_mac != BOND_FOM_ACTIVE || BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)) { if (ether_addr_equal_64bits(bond_dev->dev_addr, slave->perm_hwaddr) && bond_has_slaves(bond)) -- 2.39.5