From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F212288EE; Mon, 2 Jun 2025 14:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748874824; cv=none; b=jkUiwQFSDDTKyiWSyMGvSq/n77tIgko3CgSDHNPZqgtSaHaF1rTwRRSAHqlg9nws4sBk4lk6qjrMsyv2UMniMpmUBC9tbObPO/piNf2NJ0hR95qzTDuAmP5ttJVaPGssMcl67q0FZgWHHirmwH0l33UQlPwhXnNVjthtD2JelnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748874824; c=relaxed/simple; bh=y66gCV3EEyyYpLn52ogz3JIYpFkDQGFzcOggJMxUzxs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hm1WBR4XzaaGwcuH0kwWCc95greS9SuoSbFQ8RPVycTvwm8+Bh3fMmhrEn4clZKbZI+NM+TXWEvneZ55TNYm4AblKrx6tSE9iiT3I5XMhyE8tf0wQUyFn3PKLpxLEVCeAVs9AEc/YFMN9uKYkRAA+eCboQk6Ex0jK9LKobqwQqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fckwEohz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fckwEohz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19527C4CEEE; Mon, 2 Jun 2025 14:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748874824; bh=y66gCV3EEyyYpLn52ogz3JIYpFkDQGFzcOggJMxUzxs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fckwEohzqeYW0u3W73iTS6FXgOxQM1xPqjPjAuB7YjUIxseoLxaUlR6kktcOCuypI UzStdkUP2DQhZldLCIqO/asRs4oz/S/n2dxGfFvyYYEVBXynhZsLfz+hRoTFRndcY4 eb/HtWqSCUG5PHogaKMjsl0S9aLzzPKjZKRFmWKY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Damon Ding , Dmitry Baryshkov , Vinod Koul , Sasha Levin Subject: [PATCH 5.4 148/204] phy: core: dont require set_mode() callback for phy_get_mode() to work Date: Mon, 2 Jun 2025 15:48:01 +0200 Message-ID: <20250602134301.466147621@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134255.449974357@linuxfoundation.org> References: <20250602134255.449974357@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Baryshkov [ Upstream commit d58c04e305afbaa9dda7969151f06c4efe2c98b0 ] As reported by Damon Ding, the phy_get_mode() call doesn't work as expected unless the PHY driver has a .set_mode() call. This prompts PHY drivers to have empty stubs for .set_mode() for the sake of being able to get the mode. Make .set_mode() callback truly optional and update PHY's mode even if it there is none. Cc: Damon Ding Link: https://lore.kernel.org/r/96f8310f-93f1-4bcb-8637-137e1159ff83@rock-chips.com Tested-by: Damon Ding Signed-off-by: Dmitry Baryshkov Link: https://lore.kernel.org/r/20250209-phy-fix-set-moe-v2-1-76e248503856@linaro.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/phy-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index c94a0d2c45161..917e01af4769f 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -360,13 +360,14 @@ EXPORT_SYMBOL_GPL(phy_power_off); int phy_set_mode_ext(struct phy *phy, enum phy_mode mode, int submode) { - int ret; + int ret = 0; - if (!phy || !phy->ops->set_mode) + if (!phy) return 0; mutex_lock(&phy->mutex); - ret = phy->ops->set_mode(phy, mode, submode); + if (phy->ops->set_mode) + ret = phy->ops->set_mode(phy, mode, submode); if (!ret) phy->attrs.mode = mode; mutex_unlock(&phy->mutex); -- 2.39.5