From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7A2221FC9; Mon, 2 Jun 2025 14:39:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875143; cv=none; b=KRFknKAawNRkMiUTyxwwVL0wAKXUd8xn05DeHoUUsyUYTMcDFy2tt1JaTcRH46rTJeqU8U0rcUbuVUihuqZ9tkgZMbZVnVu3cwkpfg1B75IJmOzUiFpRopprB8kapSKwZuOwomSHi07QUu4D88ME6RALhm52vqNyhioB0uygJnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875143; c=relaxed/simple; bh=dk76xtzYaAQ4V0Xkh1Zn1MH0HKEzaQN/4YzZwbgUYfU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PEx43COdNmoXg8f6Aga1GMqLtOFrt3KnD+hylhny1p6mlF4i7SZocmwWPs3x2PtOGn7K3Vg9XI3y1Umit4e3FANco3j9m/7D6cdPX2hQ+S9GIRNYk9zaqICaVeEb5uLXU2WifaWsEv4sslLwpTcaqC3zN2xGijVaQ2PjT517jbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=G3dRg1m7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="G3dRg1m7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D56F8C4CEEB; Mon, 2 Jun 2025 14:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748875143; bh=dk76xtzYaAQ4V0Xkh1Zn1MH0HKEzaQN/4YzZwbgUYfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G3dRg1m7yN+RQ9M1fxUaDFeKEwZL7SJGlKaQQY3CHtUAAtYgr0bPlmbdQOCz5g4R5 1Zkc0nb96Lou51b8LBWrvQvgARpAxB86gGPTinu5tmG2LLhcC4gPPjHeo1NIfkltKG GQzadXxP2doscuN7TAuVm+bF4kz858XIB4myr2kQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 5.10 042/270] can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls Date: Mon, 2 Jun 2025 15:45:27 +0200 Message-ID: <20250602134308.906795452@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134307.195171844@linuxfoundation.org> References: <20250602134307.195171844@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 84f5eb833f53ae192baed4cfb8d9eaab43481fc9 upstream. If a driver is removed, the driver framework invokes the driver's remove callback. A CAN driver's remove function calls unregister_candev(), which calls net_device_ops::ndo_stop further down in the call stack for interfaces which are in the "up" state. With the mcp251xfd driver the removal of the module causes the following warning: | WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8 as can_rx_offload_del() deletes the NAPI, while it is still active, because the interface is still up. To fix the warning, first unregister the network interface, which calls net_device_ops::ndo_stop, which disables the NAPI, and then call can_rx_offload_del(). Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-1-59a9b131589d@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c @@ -2889,8 +2889,8 @@ static int mcp251xfd_remove(struct spi_d struct mcp251xfd_priv *priv = spi_get_drvdata(spi); struct net_device *ndev = priv->ndev; - can_rx_offload_del(&priv->offload); mcp251xfd_unregister(priv); + can_rx_offload_del(&priv->offload); spi->max_speed_hz = priv->spi_max_speed_hz_orig; free_candev(ndev);