From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64720227E8E; Mon, 2 Jun 2025 14:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875162; cv=none; b=XbysvBIeUq7riT5iXrAWXYzMAK6rCcWMKKl3YMFTaMkdtDkZHJVLVHJHN09Qwd2e/lVe/430wnOgtWpUX9aWOpZD0sZpFW6KjNGaOsA9oyHnSajkk1j4orK4AIm+rTtnyvFk+aBw/b7v45KQcts9u241bD4bOTnh9EImO3xePqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875162; c=relaxed/simple; bh=ggCTNRXbVzAhg6MwtD60Wl1aymzuDsoHKPm2k8j1up8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DVuDsiNAbV4NFgO7ZBfa+gfZSFkGjG+er6GqTYl6ciPfw7yXGcgEmYDHwjwN/guoxvTimmU3WoERmJui2pqaPfYYzvQSTvO5HHqldSq3YTAboICidyHVRay/GEqOFua9a9vSfIWQRBNum0WRfOmKJOpKH0SuJRCGns0nXmigtMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Hc9/8S3N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Hc9/8S3N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7C3BC4CEEB; Mon, 2 Jun 2025 14:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748875162; bh=ggCTNRXbVzAhg6MwtD60Wl1aymzuDsoHKPm2k8j1up8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hc9/8S3Nv4D161VmRFbiLo+Sche0M7aYE3M/eAZDIm5tdQ6tNWw5ixytJJYishk5r irf8BIMK51RkLl6zrQtV3mafRe16Nty2G3VdYLPCkM2TceGTJjGww9qnKI63065otL CaGR9Jb6/w7SL8ACVy7QBJ2qwKgwGtXPu6Fpg+NI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kota Toda , Jozsef Kadlecsik , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.10 047/270] netfilter: ipset: fix region locking in hash types Date: Mon, 2 Jun 2025 15:45:32 +0200 Message-ID: <20250602134309.121908361@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134307.195171844@linuxfoundation.org> References: <20250602134307.195171844@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jozsef Kadlecsik [ Upstream commit 8478a729c0462273188263136880480729e9efca ] Region locking introduced in v5.6-rc4 contained three macros to handle the region locks: ahash_bucket_start(), ahash_bucket_end() which gave back the start and end hash bucket values belonging to a given region lock and ahash_region() which should give back the region lock belonging to a given hash bucket. The latter was incorrect which can lead to a race condition between the garbage collector and adding new elements when a hash type of set is defined with timeouts. Fixes: f66ee0410b1c ("netfilter: ipset: Fix "INFO: rcu detected stall in hash_xxx" reports") Reported-by: Kota Toda Signed-off-by: Jozsef Kadlecsik Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/ipset/ip_set_hash_gen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipset/ip_set_hash_gen.h b/net/netfilter/ipset/ip_set_hash_gen.h index 093ec52140084..636118b0f2ef4 100644 --- a/net/netfilter/ipset/ip_set_hash_gen.h +++ b/net/netfilter/ipset/ip_set_hash_gen.h @@ -88,7 +88,7 @@ struct hbucket { #define ahash_sizeof_regions(htable_bits) \ (ahash_numof_locks(htable_bits) * sizeof(struct ip_set_region)) #define ahash_region(n, htable_bits) \ - ((n) % ahash_numof_locks(htable_bits)) + ((n) / jhash_size(HTABLE_REGION_BITS)) #define ahash_bucket_start(h, htable_bits) \ ((htable_bits) < HTABLE_REGION_BITS ? 0 \ : (h) * jhash_size(HTABLE_REGION_BITS)) -- 2.39.5