From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB67F225A24; Mon, 2 Jun 2025 14:49:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875752; cv=none; b=LRyBE+g+BM4LIcqZo747YrWZ1e7jVVcMzVOmEMoInLBaMxma84HDxja2ZWKtmYGmUTsQ4Bi0QhFFcQ3jjhara2YvQq+r2zG76mF0GpC/tSgPXvYC8YnjFWJcRPjVX/XahMMY9ZK44sJHc2fc2jnFGzVTstYGuQGnoJOJ1Kijo40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875752; c=relaxed/simple; bh=o1pbjYg09laUioVBeGLlAD6Tb4FsYYxQbnXBlZ69KiA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Legtiyk/2sqX9ELu7gT9YmJtnz1XQJivL673UUhS3o4j7/Tn8j9629fTx8zueoeKos5YnsKADvja+HmkGJslUHpI3SWH1z2a55THdZ1N5nXy61grgA2U0o24hbJTw4fCAxQArxRytEWFr1P+dXZPXIfE1j2FPL/1txJ0BRgxZHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J+4DIDaC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J+4DIDaC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5392CC4CEEB; Mon, 2 Jun 2025 14:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748875751; bh=o1pbjYg09laUioVBeGLlAD6Tb4FsYYxQbnXBlZ69KiA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J+4DIDaC2zJr6woWMbHl4U046sRAwF3WRf/bvbZKCk3Yv94AwpPzwn9gh+moFZaWX MmvOkE33mr4TBMoJwOTR7+an2kbw4GTGwUQJhBHqSDHuUlrYnsIoudwO1pwfpdFbVM kOzxv+gVwllmgCf6sSaYsU1YG2j/fmuDAjE9gvkU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Isaac Scott , Michael Hennerich , Mark Brown , Sasha Levin Subject: [PATCH 5.10 225/270] regulator: ad5398: Add device tree support Date: Mon, 2 Jun 2025 15:48:30 +0200 Message-ID: <20250602134316.517662223@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134307.195171844@linuxfoundation.org> References: <20250602134307.195171844@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Isaac Scott [ Upstream commit 5a6a461079decea452fdcae955bccecf92e07e97 ] Previously, the ad5398 driver used only platform_data, which is deprecated in favour of device tree. This caused the AD5398 to fail to probe as it could not load its init_data. If the AD5398 has a device tree node, pull the init_data from there using of_get_regulator_init_data. Signed-off-by: Isaac Scott Acked-by: Michael Hennerich Link: https://patch.msgid.link/20250128173143.959600-4-isaac.scott@ideasonboard.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/ad5398.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index 75f432f61e919..f4d6e62bd963e 100644 --- a/drivers/regulator/ad5398.c +++ b/drivers/regulator/ad5398.c @@ -14,6 +14,7 @@ #include #include #include +#include #define AD5398_CURRENT_EN_MASK 0x8000 @@ -221,15 +222,20 @@ static int ad5398_probe(struct i2c_client *client, const struct ad5398_current_data_format *df = (struct ad5398_current_data_format *)id->driver_data; - if (!init_data) - return -EINVAL; - chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); if (!chip) return -ENOMEM; config.dev = &client->dev; + if (client->dev.of_node) + init_data = of_get_regulator_init_data(&client->dev, + client->dev.of_node, + &ad5398_reg); + if (!init_data) + return -EINVAL; + config.init_data = init_data; + config.of_node = client->dev.of_node; config.driver_data = chip; chip->client = client; -- 2.39.5