From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384FC23185C; Mon, 2 Jun 2025 14:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875832; cv=none; b=PISeUExwk8A1pfsKfriJOFHnjiIuzjMHEEjd4GH7HGLGT+Vq4yqHosFNz2a7RpI466Xvdf0cp73DTlvKDQzW7Cb9vYe0Lwt5ZZAMGp3eXIAvXtpGdsSWTvYuXDNtlw2vBhOZSRJUKbB9Qdqxx/Rrb0FuccLmoWYXwvZEBDvHw3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748875832; c=relaxed/simple; bh=7zfLo/zi41H95NtaRNoArEmuESU+OzbWUoR1ps6/dCA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i5jtoVLE8EJQNrpBZMOESkiSP8pIrKmTXHr+7KUuoArnLB8HBAP3Has2lAawOtYeqDtGPD0pYLI4JYH2Bzy0ABKboBBrCN/EqwUMKnS4jTiax8iiO9YxmJggHftfm6UF/jnUtswlHCP3/6uFRm7tnKeSL2KIpn1erIm5fvoRt20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YwcH/8zY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YwcH/8zY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E2FCC4CEEB; Mon, 2 Jun 2025 14:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748875831; bh=7zfLo/zi41H95NtaRNoArEmuESU+OzbWUoR1ps6/dCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YwcH/8zY+SWpRTsiu+MYjrnUR4MeuuDgowDEGF0AYMPDqQ1eusdGcoHoxMHLa+RRm XaTK1qHtczRgPrUlOPBIz0QnNXZqfwqfBcIYjys/c4A+9ulLjlf1rl4OgHF25h8+Sv bb2KYTh3QYuLVnwI1m1U6nzPyf5v+QN1TbYRprVw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Martin Blumenstingl , Neil Armstrong , Linus Walleij , Sasha Levin Subject: [PATCH 5.10 228/270] pinctrl: meson: define the pull up/down resistor value as 60 kOhm Date: Mon, 2 Jun 2025 15:48:33 +0200 Message-ID: <20250602134316.637187631@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134307.195171844@linuxfoundation.org> References: <20250602134307.195171844@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Martin Blumenstingl [ Upstream commit e56088a13708757da68ad035269d69b93ac8c389 ] The public datasheets of the following Amlogic SoCs describe a typical resistor value for the built-in pull up/down resistor: - Meson8/8b/8m2: not documented - GXBB (S905): 60 kOhm - GXL (S905X): 60 kOhm - GXM (S912): 60 kOhm - G12B (S922X): 60 kOhm - SM1 (S905D3): 60 kOhm The public G12B and SM1 datasheets additionally state min and max values: - min value: 50 kOhm for both, pull-up and pull-down - max value for the pull-up: 70 kOhm - max value for the pull-down: 130 kOhm Use 60 kOhm in the pinctrl-meson driver as well so it's shown in the debugfs output. It may not be accurate for Meson8/8b/8m2 but in reality 60 kOhm is closer to the actual value than 1 Ohm. Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/20250329190132.855196-1-martin.blumenstingl@googlemail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 20683cd072bb0..ae72edba8a1f0 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -483,7 +483,7 @@ static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin, case PIN_CONFIG_BIAS_PULL_DOWN: case PIN_CONFIG_BIAS_PULL_UP: if (meson_pinconf_get_pull(pc, pin) == param) - arg = 1; + arg = 60000; else return -EINVAL; break; -- 2.39.5