From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61BB62153CB; Mon, 2 Jun 2025 15:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748876985; cv=none; b=Dzf5vuJYvvkh4J5WUQjv+9AskK0CALE2S6qQacyVXmihhBNeKkZl+MgwkFD7ahZNUZ88tfr/xHnvDq7EvTofU7OYTIntw+iXrGcKxpDCjLIJhmOQ7zWESl2p9tzUjrIhEwWUuEqYna4cjFg7+9CkdhFDOSbDsxvbjhCNMqz30RA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748876985; c=relaxed/simple; bh=PdrA/3OjuBdj6r8w5PlgxceS79mnaOps0hpx+psD+9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b/EyKgNESWiwa4DdaYFKzb+J+M1Y8lnGxakzUD3wDDN4AtSi8KnKCsnujsHwhobfz2HxPi8qwudQVIORUA20vZc0oNkpXQ3S4bLMc8RrxbxrhOa93VZ99h7Zog7iHf8oKb2WdtCwkM5VMugBcUDdTSLJHs68aPOsFxeeGg0wAIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HvZpppKC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HvZpppKC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 147B7C4CEEB; Mon, 2 Jun 2025 15:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748876981; bh=PdrA/3OjuBdj6r8w5PlgxceS79mnaOps0hpx+psD+9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HvZpppKClCqqI4dFpn9pKaZqg+khE+A8oVrikcWKYoAzIj0px/RnO6JY/4xOBgQH5 BqdK/qWosXi0xFMm/baaBCaTnjEEBwZ82S/83Ni/byetmIEcNm5Ilv+4Bv0pzoFnTm RFUvEvbCbUWg1ILn3/GWbkBPSKnpTf7V9i4EwBBE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hangbin Liu , Nikolay Aleksandrov , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 134/325] bonding: report duplicate MAC address in all situations Date: Mon, 2 Jun 2025 15:46:50 +0200 Message-ID: <20250602134325.247400181@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134319.723650984@linuxfoundation.org> References: <20250602134319.723650984@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hangbin Liu [ Upstream commit 28d68d396a1cd21591e8c6d74afbde33a7ea107e ] Normally, a bond uses the MAC address of the first added slave as the bond’s MAC address. And the bond will set active slave’s MAC address to bond’s address if fail_over_mac is set to none (0) or follow (2). When the first slave is removed, the bond will still use the removed slave’s MAC address, which can lead to a duplicate MAC address and potentially cause issues with the switch. To avoid confusion, let's warn the user in all situations, including when fail_over_mac is set to 2 or not in active-backup mode. Signed-off-by: Hangbin Liu Reviewed-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20250225033914.18617-1-liuhangbin@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index ded9e369e4038..3cedadef9c8ab 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2431,7 +2431,7 @@ static int __bond_release_one(struct net_device *bond_dev, RCU_INIT_POINTER(bond->current_arp_slave, NULL); - if (!all && (!bond->params.fail_over_mac || + if (!all && (bond->params.fail_over_mac != BOND_FOM_ACTIVE || BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)) { if (ether_addr_equal_64bits(bond_dev->dev_addr, slave->perm_hwaddr) && bond_has_slaves(bond)) -- 2.39.5