From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE1FA2C327E; Mon, 2 Jun 2025 15:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748876988; cv=none; b=tVbxvm8DyzGSdAZ7+q4PnD60GtRujlOUdcycK7rimxelwZMGW20iLD/LbguziN11P2kngeQEWTS27iMCBLlD+fWMgOyCIaIcUTQghz2i52wJ4lvWJbGoE7ho8t/HXyAk0moFlNpPBTo7YKA/oUaYcLChfAPOHla19Tevwiw1b8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748876988; c=relaxed/simple; bh=+Tx0kbOmkXm7LgNt+n7NagG0r8WKlSvBNxp+IF74blA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BHWeA95Ljc33T0SPLr6ohk6bfkyyRwq9JWuGGDjww34o7sesynorbj357KtEC219y54QTYxXUswUAnIKcY0daPRl/GBhq3lVorxer+WkXqQ356sTAJpEpozusTMIlAKrOeGO36HPPaWLJchTbepRdNhH59wGyv4lRRi8RqLvbCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L8IEHSPr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L8IEHSPr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81D62C4CEEB; Mon, 2 Jun 2025 15:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748876987; bh=+Tx0kbOmkXm7LgNt+n7NagG0r8WKlSvBNxp+IF74blA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L8IEHSPr9sPUXDxcyn+YmleCnNoc3zHjn5kjAca0HkrxiZfgtCyudVVXso1GUFHtw XgDujTTZV26/0d0pUAbv5ydFOC6IR8k/hcYC1en5WR4A8k52WrQoiHOyf4FSEHnP7h 5T9t+BTknAZFS+8AT+9/Xy1SWPKZizrnMZHeUBlc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrew Davis , Nishanth Menon , Sasha Levin Subject: [PATCH 6.1 135/325] soc: ti: k3-socinfo: Do not use syscon helper to build regmap Date: Mon, 2 Jun 2025 15:46:51 +0200 Message-ID: <20250602134325.293677514@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134319.723650984@linuxfoundation.org> References: <20250602134319.723650984@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Davis [ Upstream commit a5caf03188e44388e8c618dcbe5fffad1a249385 ] The syscon helper device_node_to_regmap() is used to fetch a regmap registered to a device node. It also currently creates this regmap if the node did not already have a regmap associated with it. This should only be used on "syscon" nodes. This driver is not such a device and instead uses device_node_to_regmap() on its own node as a hacky way to create a regmap for itself. This will not work going forward and so we should create our regmap the normal way by defining our regmap_config, fetching our memory resource, then using the normal regmap_init_mmio() function. Signed-off-by: Andrew Davis Link: https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com Signed-off-by: Nishanth Menon Signed-off-by: Sasha Levin --- drivers/soc/ti/k3-socinfo.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c index 91f441ee61752..5b0d8260918d2 100644 --- a/drivers/soc/ti/k3-socinfo.c +++ b/drivers/soc/ti/k3-socinfo.c @@ -60,6 +60,12 @@ k3_chipinfo_partno_to_names(unsigned int partno, return -EINVAL; } +static const struct regmap_config k3_chipinfo_regmap_cfg = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = 4, +}; + static int k3_chipinfo_probe(struct platform_device *pdev) { struct device_node *node = pdev->dev.of_node; @@ -67,13 +73,18 @@ static int k3_chipinfo_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct soc_device *soc_dev; struct regmap *regmap; + void __iomem *base; u32 partno_id; u32 variant; u32 jtag_id; u32 mfg; int ret; - regmap = device_node_to_regmap(node); + base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); + + regmap = regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg); if (IS_ERR(regmap)) return PTR_ERR(regmap); -- 2.39.5