From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF6B221FB8; Mon, 2 Jun 2025 14:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748873326; cv=none; b=ZshZxWuoblvEA/i+rYUOTi2ngmkF5WmXbytWaultODxXtqzHt4lyenlX41f/5x44UXAVk3U2M592PiQz1V1FzySnxAvnIeUnKkId7N9qJGENdBJVX4iwSkr56K7RLmk14diM7aelQkHPXM5xp8mNAVdw8iR4cgmJ6PdtYO6FpRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748873326; c=relaxed/simple; bh=Q23KaX5piq1+xkO6jeS+gNQPm8MKrtOlszkDpUb8QFE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VXHn+sky86fmb/wqhqcFwpLF+AwtP+44DyLtOWUD2M6gZl28j2O2O6Mh8eKGWnkPOlvaMzbZ2Aa0/+ov4oCFTVZbaADmZsp5kqwgEP7OksyEYU1FT6E7Ic18zO9mATDNESMlO9eQnPH/49s0LGBXL+Al5vADX4GeBK+JqkSA/lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mHlU/8/J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mHlU/8/J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C7C3C4CEEB; Mon, 2 Jun 2025 14:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748873325; bh=Q23KaX5piq1+xkO6jeS+gNQPm8MKrtOlszkDpUb8QFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mHlU/8/JbHpLD/G9xNU2UgeFlgQqxXKyVhGunD2QZr8DnVFPTBfasYOO+OEdvVP9a kzJ3XDfA86bNIgtUWukADgvkUgxls5TGmr4Em89dN5mFY9YvNsOMcfsUqYXroUt25H ypMaSb0LTM9FGb+0ePh7MlyWDuXmR9OdYUQUzh20= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shree Ramamoorthy , Lee Jones , Sasha Levin Subject: [PATCH 6.6 105/444] mfd: tps65219: Remove TPS65219_REG_TI_DEV_ID check Date: Mon, 2 Jun 2025 15:42:49 +0200 Message-ID: <20250602134345.164422630@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134340.906731340@linuxfoundation.org> References: <20250602134340.906731340@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shree Ramamoorthy [ Upstream commit 76b58d5111fdcffce615beb71520bc7a6f1742c9 ] The chipid macro/variable and regmap_read function call is not needed because the TPS65219_REG_TI_DEV_ID register value is not a consistent value across TPS65219 PMIC config versions. Reading from the DEV_ID register without a consistent value to compare it to isn't useful. There isn't a way to verify the match data ID is the same ID read from the DEV_ID device register. 0xF0 isn't a DEV_ID value consistent across TPS65219 NVM configurations. For TPS65215, there is a consistent value in bits 5-0 of the DEV_ID register. However, there are other error checks in place within probe() that apply to both PMICs rather than keeping this isolated check for one PMIC. Signed-off-by: Shree Ramamoorthy Link: https://lore.kernel.org/r/20250206173725.386720-4-s-ramamoorthy@ti.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/tps65219.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c index 0e0c42e4fdfc7..72a5f51fe32a5 100644 --- a/drivers/mfd/tps65219.c +++ b/drivers/mfd/tps65219.c @@ -228,7 +228,6 @@ static struct regmap_irq_chip tps65219_irq_chip = { static int tps65219_probe(struct i2c_client *client) { struct tps65219 *tps; - unsigned int chipid; bool pwr_button; int ret; @@ -253,12 +252,6 @@ static int tps65219_probe(struct i2c_client *client) if (ret) return ret; - ret = regmap_read(tps->regmap, TPS65219_REG_TI_DEV_ID, &chipid); - if (ret) { - dev_err(tps->dev, "Failed to read device ID: %d\n", ret); - return ret; - } - ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65219_cells, ARRAY_SIZE(tps65219_cells), NULL, 0, regmap_irq_get_domain(tps->irq_data)); -- 2.39.5