public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6.1.y] arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM
@ 2025-06-02 15:58 Francesco Dolcini
  2025-06-03 18:36 ` Sasha Levin
  2025-06-04 13:24 ` Greg Kroah-Hartman
  0 siblings, 2 replies; 3+ messages in thread
From: Francesco Dolcini @ 2025-06-02 15:58 UTC (permalink / raw)
  To: stable
  Cc: Marek Vasut, Greg Kroah-Hartman, patches, Sasha Levin,
	Frieder Schrempf, Shawn Guo

From: Marek Vasut <marex@denx.de>

[ Upstream commit 8bad8c923f217d238ba4f1a6d19d761e53bfbd26 ]

The VSELECT pin is configured as MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT
and not as a GPIO, drop the bogus sd-vsel-gpios property as the eSDHC
block handles the VSELECT pin on its own.

Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---
6.1.y is currently broken on imx8mm-verdin, because commit
5591ce0069ddda97cdbbea596bed53e698f399c2, that was backported correctly on 6.1,
depends on this one.

This fixes the following error:

[    1.735149] gpio-regulator: probe of regulator-usdhc2-vqmmc failed with error -16

---
 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
index 5b2493bb8dd9..37acaf62f5c7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
@@ -362,7 +362,6 @@ pca9450: pmic@25 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		reg = <0x25>;
-		sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
 
 		/*
 		 * The bootloader is expected to switch on the I2C level shifter for the TLA2024 ADC
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 6.1.y] arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM
  2025-06-02 15:58 [PATCH 6.1.y] arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM Francesco Dolcini
@ 2025-06-03 18:36 ` Sasha Levin
  2025-06-04 13:24 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2025-06-03 18:36 UTC (permalink / raw)
  To: stable; +Cc: Francesco Dolcini, Sasha Levin

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 8bad8c923f217d238ba4f1a6d19d761e53bfbd26

WARNING: Author mismatch between patch and upstream commit:
Backport author: Francesco Dolcini<francesco@dolcini.it>
Commit author: Marek Vasut<marex@denx.de>

Status in newer kernel trees:
6.15.y | Present (exact SHA1)
6.14.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)

Note: The patch differs from the upstream commit:
---
1:  8bad8c923f217 ! 1:  a0da60f537dd7 arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM
    @@ Metadata
      ## Commit message ##
         arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM
     
    +    [ Upstream commit 8bad8c923f217d238ba4f1a6d19d761e53bfbd26 ]
    +
         The VSELECT pin is configured as MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT
         and not as a GPIO, drop the bogus sd-vsel-gpios property as the eSDHC
         block handles the VSELECT pin on its own.
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y        |  Success    |  Success   |

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 6.1.y] arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM
  2025-06-02 15:58 [PATCH 6.1.y] arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM Francesco Dolcini
  2025-06-03 18:36 ` Sasha Levin
@ 2025-06-04 13:24 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-04 13:24 UTC (permalink / raw)
  To: Francesco Dolcini
  Cc: stable, Marek Vasut, patches, Sasha Levin, Frieder Schrempf,
	Shawn Guo

On Mon, Jun 02, 2025 at 05:58:45PM +0200, Francesco Dolcini wrote:
> From: Marek Vasut <marex@denx.de>
> 
> [ Upstream commit 8bad8c923f217d238ba4f1a6d19d761e53bfbd26 ]
> 
> The VSELECT pin is configured as MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT
> and not as a GPIO, drop the bogus sd-vsel-gpios property as the eSDHC
> block handles the VSELECT pin on its own.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
> 6.1.y is currently broken on imx8mm-verdin, because commit
> 5591ce0069ddda97cdbbea596bed53e698f399c2, that was backported correctly on 6.1,
> depends on this one.
> 
> This fixes the following error:
> 
> [    1.735149] gpio-regulator: probe of regulator-usdhc2-vqmmc failed with error -16

You forgot to sign off on this patch you forwarded on :(

Can you resend with that fixed up?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-04 13:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-02 15:58 [PATCH 6.1.y] arm64: dts: imx8mm: Drop sd-vsel-gpios from i.MX8M Mini Verdin SoM Francesco Dolcini
2025-06-03 18:36 ` Sasha Levin
2025-06-04 13:24 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox