From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A920E1A275; Fri, 6 Jun 2025 06:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749190819; cv=none; b=Wxb2d3xfYL7DH9ALJRrxHA04bbgqBnEIrg+wHjfsqoefvNq5KcwgXLyfzDegNFB1I3nbQFTtayxsL9sjrx4G3jRy1lFi/XaEXQdErLGhXRrcpM/2LOZUrhP94Cy/FJvbEraeMJaL4/yFATdKtE5rFIRAjvY6gpMR4f/TleAJbSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749190819; c=relaxed/simple; bh=GGMZQDha5MME4iV+ZVJ8ZscSVZP5hFu772k1h5zEqCI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KFhRr5VTH94VwkjP85saH5UFhQCbmipU3HxoCNUaDg/JFsiVTXmtTGSt37H0lvakXliPsgiUElBnv/HEEMgcUaykA0+fzDQyheKUr9WxgCx/uxsG1iQTFI6HAOogFwha8FtDendO9tdrhSOelN4BBjxwxkq7kYPEzGEotXh0FIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NG6VHckx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NG6VHckx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F566C4CEEB; Fri, 6 Jun 2025 06:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1749190815; bh=GGMZQDha5MME4iV+ZVJ8ZscSVZP5hFu772k1h5zEqCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NG6VHckx30kUej5V4Kr04DCOHZwDL00/lv96YfccQDVPxGLnVxnN19fkpd06Q7z+W +wSkJKSmIJ+jovm1QJZswbkVpKJq7g1WRyepEFe5L6FqckgJKJ9Dx/nadmXuyTHVhK 14PhjdFAFLkspzBpmqz08re85GhPrGk9uSE21BYA= Date: Fri, 6 Jun 2025 08:20:10 +0200 From: Greg KH To: Suleiman Souhlal Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Masahiro Yamada , Ian Rogers , ssouhlal@freebsd.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org Subject: Re: [RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang. Message-ID: <2025060620-stainless-unedited-ddfc@gregkh> References: <20250606052301.810338-1-suleiman@google.com> <20250606053650.863215-1-suleiman@google.com> <2025060650-detached-boozy-8716@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jun 06, 2025 at 03:08:09PM +0900, Suleiman Souhlal wrote: > On Fri, Jun 6, 2025 at 3:05 PM Greg KH wrote: > > > > On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote: > > > When cross compiling the kernel with clang, we need to override > > > CLANG_CROSS_FLAGS when preparing the step libraries for > > > resolve_btfids. > > > > > > Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs > > > when building tools in parallel"), MAKEFLAGS would have been set to a > > > value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the > > > fact that we weren't properly overriding it. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program") > > > Signed-off-by: Suleiman Souhlal > > > --- > > > tools/bpf/resolve_btfids/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > You forgot to say why this is a resend :( > > I wasn't sure how to say it. It didn't occur to me that I could have > replied to it with the reason. That goes below the --- line and it would be a v2, not a RESEND as you changed something: > It was because I had "Signed-of-by:" instead of "Signed-off-by:". Which means it was not identical to the first version (a RESEND means a maintainer can take either as they are the same). thanks, greg k-h