From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Wentao Guan <guanwentao@uniontech.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Sasha Levin <sashal@kernel.org>,
rafael@kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH AUTOSEL 6.15 12/15] ACPI: resource: Use IRQ override on MACHENIKE 16P
Date: Tue, 17 Jun 2025 08:21:42 -0400 [thread overview]
Message-ID: <20250617122147.1968355-12-sashal@kernel.org> (raw)
In-Reply-To: <20250617122147.1968355-1-sashal@kernel.org>
From: Wentao Guan <guanwentao@uniontech.com>
[ Upstream commit c99ad987d3e9b550e9839d5df22de97d90462e5f ]
Use ACPI IRQ override on MACHENIKE laptop to make the internal
keyboard work.
Add a new entry to the irq1_edge_low_force_override structure, similar
to the existing ones.
Link: https://bbs.deepin.org.cn/zh/post/287628
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Link: https://patch.msgid.link/20250603122059.1072790-1-guanwentao@uniontech.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
**YES**
This commit should be backported to stable kernel trees for the
following reasons:
1. **Bug Fix for Non-Functional Hardware**: The commit fixes a broken
keyboard on MACHENIKE 16P laptops. The internal keyboard does not
work without this IRQ override, which is a significant hardware
functionality issue that affects users.
2. **Small and Contained Change**: The change is minimal - it only adds
7 lines to add a new DMI match entry to the existing
`irq1_edge_low_force_override` array:
```c
+ {
+ /* MACHENIKE L16P/L16P */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "MACHENIKE"),
+ DMI_MATCH(DMI_BOARD_NAME, "L16P"),
+ },
+ },
```
3. **Well-Established Pattern**: This follows an established pattern in
the kernel. The code shows this is part of a long-standing mechanism
for handling keyboard IRQ issues on AMD Zen platforms where "the DSDT
specifies the kbd IRQ as falling edge and this must be overridden to
rising edge, to have a working keyboard."
4. **Similar Commits Were Backported**: Looking at the historical
commits provided:
- "ACPI: resource: Do IRQ override on TongFang GXxHRXx and GMxHGxx" -
marked with "Cc: All applicable <stable@vger.kernel.org>"
- "ACPI: resource: Do IRQ override on MECHREV GM7XG0M" - includes
both "Fixes:" tag and "Cc: All applicable <stable@vger.kernel.org>"
- "ACPI: resource: Do IRQ override on Lunnen Ground laptops" - marked
as YES for backporting
- "ACPI: resource: IRQ override for Eluktronics MECH-17" - marked as
YES for backporting
5. **No Risk of Regression**: The change is isolated to MACHENIKE 16P
laptops only (via DMI matching), so it cannot affect other systems.
The DMI match ensures this override only applies to the specific
hardware that needs it.
6. **Critical Functionality**: A non-functional keyboard is a critical
issue that prevents normal system usage. This is not a minor
inconvenience but a complete loss of primary input functionality.
The only reason this commit might not have been explicitly marked for
stable is an oversight, as virtually identical commits for other laptop
models fixing the same keyboard IRQ issue have been consistently
backported to stable trees.
drivers/acpi/resource.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 14c7bac4100b4..9d9921f70855c 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -666,6 +666,13 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
DMI_MATCH(DMI_BOARD_NAME, "GMxHGxx"),
},
},
+ {
+ /* MACHENIKE L16P/L16P */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "MACHENIKE"),
+ DMI_MATCH(DMI_BOARD_NAME, "L16P"),
+ },
+ },
{
/*
* TongFang GM5HG0A in case of the SKIKK Vanaheim relabel the
--
2.39.5
next prev parent reply other threads:[~2025-06-17 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 12:21 [PATCH AUTOSEL 6.15 01/15] riscv: add a data fence for CMODX in the kernel mode Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 02/15] s390/mm: Fix in_atomic() handling in do_secure_storage_access() Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 03/15] riscv: misaligned: declare misaligned_access_speed under CONFIG_RISCV_MISALIGNED Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 04/15] ALSA: hda: Ignore unsol events for cards being shut down Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 05/15] ALSA: hda: Add new pci id for AMD GPU display HD audio controller Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 06/15] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 07/15] ASoC: rt1320: fix speaker noise when volume bar is 100% Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 08/15] ceph: fix possible integer overflow in ceph_zero_objects() Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 09/15] scsi: ufs: core: Don't perform UFS clkscaling during host async scan Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 10/15] riscv: save the SR_SUM status over switches Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 11/15] ovl: Check for NULL d_inode() in ovl_dentry_upper() Sasha Levin
2025-06-17 12:21 ` Sasha Levin [this message]
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 13/15] scsi: error: alua: I/O errors for ALUA state transitions Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 14/15] wil6210: fix support for sparrow chipsets Sasha Levin
2025-06-17 12:21 ` [PATCH AUTOSEL 6.15 15/15] wifi: ath10k: Avoid vdev delete timeout when firmware is already down Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617122147.1968355-12-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=guanwentao@uniontech.com \
--cc=linux-acpi@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox