From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F122E8E05; Tue, 17 Jun 2025 16:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750178118; cv=none; b=kU38JNRCaExpyPhe3TPjvvG6YR1TB17g6wCyBOdLVR26Cl0GKBId9aogJkx/OllA6ShVACyTeTIERSvDOTv9Ajfn4UGfqroCwuams8SQm7kwq3bzCQ2dceQUSZC6KEtKY3NJUt4c0o1ooYowIDizuMfI03g3WFYUlmWaM3wIOfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750178118; c=relaxed/simple; bh=6yyErsA2hvimMb4chFnarArcDz39riXz2BNcdtKVCEA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c4ZEuBMe3o9v6jf/ECqjKp7vcxOmnHT96gr8M/HljmqPfnZdmzj5OFJ7eyqkdzHHZvXSuMzfQsauj6SkFSPzGLz//B+tRgvaeIdwfzrjPGfQb/TXCBt/cajBH7AEg6wKYVM7o0CgbtD1j6IgjjABuqlcxc6BvU4joa0N+EutOgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c5U8LjzE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c5U8LjzE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 045F4C4CEE3; Tue, 17 Jun 2025 16:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750178118; bh=6yyErsA2hvimMb4chFnarArcDz39riXz2BNcdtKVCEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c5U8LjzEBGJECGRBXjciHvrUrwrgynQZ4WVHqb75A3JeEv1TpsdFcey/OG/Q1+oIE f7ieJywQ3ydmUKJOhqtC0DZbYhWaPCPv9UZRsazZfvdqDd+rLlJuE5h+HQOft5F9oR HcH7Sb1TT2BZob6GZH6KEvjc4969BxN/ljUezWCY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Robert Malz , Rafal Romanowski , Tony Nguyen , Sasha Levin Subject: [PATCH 6.12 449/512] i40e: return false from i40e_reset_vf if reset is in progress Date: Tue, 17 Jun 2025 17:26:55 +0200 Message-ID: <20250617152437.756560574@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250617152419.512865572@linuxfoundation.org> References: <20250617152419.512865572@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Robert Malz [ Upstream commit a2c90d63b71223d69a813333c1abf4fdacddbbe5 ] The function i40e_vc_reset_vf attempts, up to 20 times, to handle a VF reset request, using the return value of i40e_reset_vf as an indicator of whether the reset was successfully triggered. Currently, i40e_reset_vf always returns true, which causes new reset requests to be ignored if a different VF reset is already in progress. This patch updates the return value of i40e_reset_vf to reflect when another VF reset is in progress, allowing the caller to properly use the retry mechanism. Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered on another VF") Signed-off-by: Robert Malz Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c index dfa785e39458d..bde41d30c69ee 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -1546,8 +1546,8 @@ static void i40e_cleanup_reset_vf(struct i40e_vf *vf) * @vf: pointer to the VF structure * @flr: VFLR was issued or not * - * Returns true if the VF is in reset, resets successfully, or resets - * are disabled and false otherwise. + * Return: True if reset was performed successfully or if resets are disabled. + * False if reset is already in progress. **/ bool i40e_reset_vf(struct i40e_vf *vf, bool flr) { @@ -1566,7 +1566,7 @@ bool i40e_reset_vf(struct i40e_vf *vf, bool flr) /* If VF is being reset already we don't need to continue. */ if (test_and_set_bit(I40E_VF_STATE_RESETTING, &vf->vf_states)) - return true; + return false; i40e_trigger_vf_reset(vf, flr); -- 2.39.5