From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425AC2EA160; Tue, 17 Jun 2025 16:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750178556; cv=none; b=GH1iqPNC5QSwzxSWysZIegmZPm9DHU5BkFc7LFCGpkMiV92PMW7lVhtzaYHu4uRkVA9cks9bqpH4YtxndgW9GdPbjzDq2GYPS7ClFyXBRvv2+s0YPbzOPrd1ed64IjL0JH0w2VGGZz0mCF2kbLSUbQAwcPzNDJ37uO1xAxqi34A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750178556; c=relaxed/simple; bh=VtbNkd8FlZmykwVXbMyPbC3T2fQfwrNuAwBkyKHp0xY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N3q6g2M9+abUpXda5UADUMvJ5pCq/3OtKilWkxNNWwyagTjXEbPsHUdSLK5nRMPjWNxj2k/gTgFBpY4nbWkIQ6VD/7aNdWuRXft+XlT11HCgogR7zLLSrIS7oPozOLnjIAzPoGml+huM9pn+fIju6W8cptkEb5AUeAk7PcpLxnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=h69Hf4p5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="h69Hf4p5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55557C4CEE3; Tue, 17 Jun 2025 16:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750178554; bh=VtbNkd8FlZmykwVXbMyPbC3T2fQfwrNuAwBkyKHp0xY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h69Hf4p5P35hrObfG3MZyM53Zw08G2oFmtMZGso2G+d/VPa7uYgi/mK6XiLy1kWrx 7c4fsIk6u0XIc1qNbCKMuWmn8hgxiTxzqhCFWbns/wNmz2SjK95inlXCwVdB4Ajlww XiNFO25TkTlbtHNLjcBKt+1QoBkZCL27X/Skv24o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Peter Korsgaard , Michal Simek , Srinivas Kandagatla Subject: [PATCH 6.12 488/512] nvmem: zynqmp_nvmem: unbreak driver after cleanup Date: Tue, 17 Jun 2025 17:27:34 +0200 Message-ID: <20250617152439.402010849@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250617152419.512865572@linuxfoundation.org> References: <20250617152419.512865572@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Korsgaard commit fe8abdd175d7b547ae1a612757e7902bcd62e9cf upstream. Commit 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup") changed the driver to expect the device pointer to be passed as the "context", but in nvmem the context parameter comes from nvmem_config.priv which is never set - Leading to null pointer exceptions when the device is accessed. Fixes: 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup") Cc: stable Signed-off-by: Peter Korsgaard Reviewed-by: Michal Simek Tested-by: Michal Simek Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20250509122407.11763-3-srini@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/nvmem/zynqmp_nvmem.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/nvmem/zynqmp_nvmem.c +++ b/drivers/nvmem/zynqmp_nvmem.c @@ -213,6 +213,7 @@ static int zynqmp_nvmem_probe(struct pla econfig.word_size = 1; econfig.size = ZYNQMP_NVMEM_SIZE; econfig.dev = dev; + econfig.priv = dev; econfig.add_legacy_fixed_of_cells = true; econfig.reg_read = zynqmp_nvmem_read; econfig.reg_write = zynqmp_nvmem_write;