From: Nathan Chancellor <nathan@kernel.org>
To: gregkh@linuxfoundation.org
Cc: thomas.weissschuh@linutronix.de, masahiroy@kernel.org,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] kbuild: userprogs: fix bitsize and target detection on clang" failed to apply to 5.4-stable tree
Date: Tue, 17 Jun 2025 16:20:06 -0700 [thread overview]
Message-ID: <20250617232006.GB3356351@ax162> (raw)
In-Reply-To: <2025061733-fineness-scale-bebf@gregkh>
On Tue, Jun 17, 2025 at 05:08:33PM +0200, gregkh@linuxfoundation.org wrote:
> From 1b71c2fb04e7a713abc6edde4a412416ff3158f2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>
> Date: Thu, 13 Feb 2025 15:55:17 +0100
> Subject: [PATCH] kbuild: userprogs: fix bitsize and target detection on clang
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> scripts/Makefile.clang was changed in the linked commit to move --target from
> KBUILD_CFLAGS to KBUILD_CPPFLAGS, as that generally has a broader scope.
> However that variable is not inspected by the userprogs logic,
> breaking cross compilation on clang.
>
> Use both variables to detect bitsize and target arguments for userprogs.
>
> Fixes: feb843a469fb ("kbuild: add $(CLANG_FLAGS) to KBUILD_CPPFLAGS")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks for figuring out that I missed picking this up in my backports.
This is not needed in 5.4 because the userprogs infrastructure was added
in 5.8 with commit 7f3a59db274c ("kbuild: add infrastructure to build
userspace programs").
Cheers,
Nathan
prev parent reply other threads:[~2025-06-17 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 15:08 FAILED: patch "[PATCH] kbuild: userprogs: fix bitsize and target detection on clang" failed to apply to 5.4-stable tree gregkh
2025-06-17 23:20 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617232006.GB3356351@ax162 \
--to=nathan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=masahiroy@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox