From: Nathan Chancellor <nathan@kernel.org>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] kbuild: hdrcheck: fix cross build with clang" failed to apply to 5.4-stable tree
Date: Tue, 17 Jun 2025 16:32:00 -0700 [thread overview]
Message-ID: <20250617233200.GC3356351@ax162> (raw)
In-Reply-To: <2025061706-stylishly-ravioli-ffa1@gregkh>
On Tue, Jun 17, 2025 at 05:10:06PM +0200, gregkh@linuxfoundation.org wrote:
> From 02e9a22ceef0227175e391902d8760425fa072c6 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Tue, 25 Feb 2025 11:00:31 +0100
> Subject: [PATCH] kbuild: hdrcheck: fix cross build with clang
>
> The headercheck tries to call clang with a mix of compiler arguments
> that don't include the target architecture. When building e.g. x86
> headers on arm64, this produces a warning like
>
> clang: warning: unknown platform, assuming -mfloat-abi=soft
>
> Add in the KBUILD_CPPFLAGS, which contain the target, in order to make it
> build properly.
>
> See also 1b71c2fb04e7 ("kbuild: userprogs: fix bitsize and target
> detection on clang").
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> Fixes: feb843a469fb ("kbuild: add $(CLANG_FLAGS) to KBUILD_CPPFLAGS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 6c6de1b1622b..e3d6b03527fe 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -10,7 +10,7 @@ UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration
>
> # In theory, we do not care -m32 or -m64 for header compile tests.
> # It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64.
> -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS))
> +UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS))
>
> # USERCFLAGS might contain sysroot location for CC.
> UAPI_CFLAGS += $(USERCFLAGS)
>
Commit 9fbed27a7a11 ("kbuild: add --target to correctly cross-compile
UAPI headers with Clang") in 5.18 introduced '--target=' here; prior to
that change, feb843a469fb would have no effect, so this change is
unnecessary for 5.15, 5.10, and 5.4 (the current 5.10 and 5.15 backports
are not harmful but they do not do anything as far as I can tell).
Cheers,
Nathan
prev parent reply other threads:[~2025-06-17 23:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 15:10 FAILED: patch "[PATCH] kbuild: hdrcheck: fix cross build with clang" failed to apply to 5.4-stable tree gregkh
2025-06-17 23:32 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617233200.GC3356351@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).