From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
stable@vger.kernel.org, stable-commits@vger.kernel.org,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: Patch "powerpc: do not build ppc_save_regs.o always" has been added to the 6.15-stable tree
Date: Tue, 17 Jun 2025 15:46:32 +0200 [thread overview]
Message-ID: <2025061725-manor-module-d648@gregkh> (raw)
In-Reply-To: <8242fbd5-85f8-4ab0-b796-24d0048e8bdc@kernel.org>
On Wed, Jun 11, 2025 at 12:15:07PM +0200, Jiri Slaby wrote:
> On 11. 06. 25, 7:39, Christophe Leroy wrote:
> >
> >
> > Le 11/06/2025 à 06:15, Jiri Slaby a écrit :
> > > On 10. 06. 25, 13:56, Sasha Levin wrote:
> > > > This is a note to let you know that I've just added the patch titled
> > > >
> > > > powerpc: do not build ppc_save_regs.o always
> > > >
> > > > to the 6.15-stable tree which can be found at:
> > > > https://eur01.safelinks.protection.outlook.com/? url=http%3A%2F%2Fwww.kernel.org%2Fgit%2F%3Fp%3Dlinux%2Fkernel%2Fgit%2Fstable%2Fstable-queue.git%3Ba%3Dsummary&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cf9c2453dd6154212e43a08dda89ea845%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638852121563909145%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=ckwC5j7O2j%2FATCggT3jwcKl3K5HRVpwA7DxjZUGnwZg%3D&reserved=0
> > >
> > > Please drop this from all trees. It was correctly broken. The whole
> > > if was removed later by 93bd4a80efeb521314485a06d8c21157240497bb.
> >
> > Isn't it better to keep it and add 93bd4a80efeb ("powerpc/kernel: Fix
> > ppc_save_regs inclusion in build") instead of droping it and keep a bad
> > test that works by chance ?
>
> Makes sense to me too (it worked by a chance for almost a decade). So all or
> nothing...
Ok, I've done that now, thanks.
greg k-h
prev parent reply other threads:[~2025-06-17 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250610115602.1537089-1-sashal@kernel.org>
2025-06-11 4:15 ` Patch "powerpc: do not build ppc_save_regs.o always" has been added to the 6.15-stable tree Jiri Slaby
2025-06-11 5:39 ` Christophe Leroy
2025-06-11 10:15 ` Jiri Slaby
2025-06-17 13:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025061725-manor-module-d648@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jirislaby@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox