Re: Patch "net: sch_ets: Add a new Qdisc" has been added to the 5.4-stable tree

Re: Patch "net: sch_ets: Add a new Qdisc" has been added to the 5.4-stable tree

[Petr Machata]

Sasha Levin <sashal@kernel.org> writes:

> This is a note to let you know that I've just added the patch titled
>
>     net: sch_ets: Add a new Qdisc
>
> to the 5.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
>      net-sch_ets-add-a-new-qdisc.patch
> and it can be found in the queue-5.4 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

Not sure what the motivation is to include a pure added feature to a
stable tree. But if you truly want the patch, then there were a couple
follow up fixes over the years. At least the following look like patches
to code that would be problematic in 5.4.y as well:

cd9b50adc6bb ("net/sched: ets: fix crash when flipping from 'strict' to 'quantum'")
454d3e1ae057 ("net/sched: sch_ets: properly init all active DRR list handles")
de6d25924c2a ("net/sched: sch_ets: don't peek at classes beyond 'nbands'")
c062f2a0b04d ("net/sched: sch_ets: don't remove idle classes from the round-robin list")
d62b04fca434 ("net: sched: fix ets qdisc OOB Indexing")
1a6d0c00fa07 ("net_sched: ets: Fix double list add in class with netem as child qdisc")

Re: Patch "net: sch_ets: Add a new Qdisc" has been added to the 5.4-stable tree

[Cong Wang]

On Mon, Jun 16, 2025 at 7:05 AM Petr Machata <petrm@nvidia.com> wrote:
>
>
> Sasha Levin <sashal@kernel.org> writes:
>
> > This is a note to let you know that I've just added the patch titled
> >
> >     net: sch_ets: Add a new Qdisc
> >
> > to the 5.4-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> >      net-sch_ets-add-a-new-qdisc.patch
> > and it can be found in the queue-5.4 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
>
> Not sure what the motivation is to include a pure added feature to a
> stable tree. But if you truly want the patch, then there were a couple
> follow up fixes over the years. At least the following look like patches
> to code that would be problematic in 5.4.y as well:

I blindly guess it got accidentally pulled into -stable due to Fixes tag?

Could we drop this please?

Thanks for catching this!

Re: Patch "net: sch_ets: Add a new Qdisc" has been added to the 5.4-stable tree

[Greg KH]

On Mon, Jun 16, 2025 at 06:07:02PM -0700, Cong Wang wrote:
> On Mon, Jun 16, 2025 at 7:05 AM Petr Machata <petrm@nvidia.com> wrote:
> >
> >
> > Sasha Levin <sashal@kernel.org> writes:
> >
> > > This is a note to let you know that I've just added the patch titled
> > >
> > >     net: sch_ets: Add a new Qdisc
> > >
> > > to the 5.4-stable tree which can be found at:
> > >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > > The filename of the patch is:
> > >      net-sch_ets-add-a-new-qdisc.patch
> > > and it can be found in the queue-5.4 subdirectory.
> > >
> > > If you, or anyone else, feels it should not be added to the stable tree,
> > > please let <stable@vger.kernel.org> know about it.
> >
> > Not sure what the motivation is to include a pure added feature to a
> > stable tree. But if you truly want the patch, then there were a couple
> > follow up fixes over the years. At least the following look like patches
> > to code that would be problematic in 5.4.y as well:
> 
> I blindly guess it got accidentally pulled into -stable due to Fixes tag?
> 
> Could we drop this please?

Now dropped.

thanks,

greg k-h