From: Peter Chen <peter.chen@cixtech.com>
To: fugang.duan@cixtech.com
Cc: cix-kernel-upstream@cixtech.com,
Peter Chen <peter.chen@cixtech.com>,
stable@vger.kernel.org,
Hongliang Yang <hongliang.yang@cixtech.com>
Subject: [PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot
Date: Wed, 18 Jun 2025 17:53:21 +0800 [thread overview]
Message-ID: <20250618095321.34213-1-peter.chen@cixtech.com> (raw)
It doesn't need to do it, and the related command event returns
'Slot Not Enabled Error' status.
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
cc: stable@vger.kernel.org
Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com>
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
---
drivers/usb/cdns3/cdnsp-ring.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
index fd06cb85c4ea..757fdd918286 100644
--- a/drivers/usb/cdns3/cdnsp-ring.c
+++ b/drivers/usb/cdns3/cdnsp-ring.c
@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id)
}
if (port_id != old_port) {
- cdnsp_disable_slot(pdev);
+ if (pdev->slot_id)
+ cdnsp_disable_slot(pdev);
+
pdev->active_port = port;
cdnsp_enable_slot(pdev);
}
--
2.25.1
next reply other threads:[~2025-06-18 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 9:53 Peter Chen [this message]
2025-06-18 13:04 ` 回复: [PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot Fugang Duan
2025-07-01 9:34 ` Greg KH
2025-07-01 9:43 ` Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2025-06-19 1:34 Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618095321.34213-1-peter.chen@cixtech.com \
--to=peter.chen@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=fugang.duan@cixtech.com \
--cc=hongliang.yang@cixtech.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox