From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D0A1DED53 for ; Fri, 20 Jun 2025 05:41:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750398118; cv=none; b=e5C268cjrxptV+/3raCSdPXooihgDEZPtYinLwFPx9hTVwobNSv9lS/vRVHe1Zej1Xp0GQ1Gq9mPMK+H4iqLJpsc/dwrkuzlQP7LABVlTII+VGVNqu5gw3A25cUT7O7eLoJpabXYq9KmXSZ7AhbLNPO5GFkE/O7NgRqad74A5QE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750398118; c=relaxed/simple; bh=lVRNs24HvtTUXLWXkevIQQ4nGj6gB92X+ny8PHJicDE=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=o5KBwmmD0W1HEDUxDRDRemTnSZONTB7z4izWYfRjt3Y3H11xhHvtmvRxyxibfuhEeLZayS6BrQM+ci8F1Jur7Ab+zi8fNciNWPFPZKpqe5DxugigY0aPqr+SQUidMlNTNUGUL1n3MnAcbb4rQ8UFq6XPoEqOHNMaq4Zi35g1I18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WwuZ6XxX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WwuZ6XxX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5ED1C4CEE3; Fri, 20 Jun 2025 05:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750398118; bh=lVRNs24HvtTUXLWXkevIQQ4nGj6gB92X+ny8PHJicDE=; h=Subject:To:Cc:From:Date:From; b=WwuZ6XxX14/PunIc3ju/4k0s0HLvoMOcQuCDQUhW7KFkM54Qn9ytNh3LBOs/AnfVr Q0CztaeYGF9ebANHZxrZE8MtRJKmAeVnL2mNj0D1ol2LQ68sidnVcb+bYhqPsbweLq 7fbH/7ptwA41Djy+1F6NOmDEaOvpo4X+ZwYwXHrI= Subject: FAILED: patch "[PATCH] s390/pci: Remove redundant bus removal and disable from" failed to apply to 5.10-stable tree To: schnelle@linux.ibm.com,gbayer@linux.ibm.com,hca@linux.ibm.com,julianr@linux.ibm.com Cc: From: Date: Fri, 20 Jun 2025 07:41:40 +0200 Message-ID: <2025062039-width-famished-433f@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x d76f9633296785343d45f85199f4138cb724b6d2 # git commit -s git send-email --to '' --in-reply-to '2025062039-width-famished-433f@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d76f9633296785343d45f85199f4138cb724b6d2 Mon Sep 17 00:00:00 2001 From: Niklas Schnelle Date: Thu, 22 May 2025 14:13:12 +0200 Subject: [PATCH] s390/pci: Remove redundant bus removal and disable from zpci_release_device() Remove zpci_bus_remove_device() and zpci_disable_device() calls from zpci_release_device(). These calls were done when the device transitioned into the ZPCI_FN_STATE_STANDBY state which is guaranteed to happen before it enters the ZPCI_FN_STATE_RESERVED state. When zpci_release_device() is called the device is known to be in the ZPCI_FN_STATE_RESERVED state which is also checked by a WARN_ON(). Cc: stable@vger.kernel.org Fixes: a46044a92add ("s390/pci: fix zpci_zdev_put() on reserve") Reviewed-by: Gerd Bayer Reviewed-by: Julian Ruess Tested-by: Gerd Bayer Signed-off-by: Niklas Schnelle Signed-off-by: Heiko Carstens diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index 5bbdc4190b8b..9fcc6d3180f2 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -949,12 +949,6 @@ void zpci_release_device(struct kref *kref) WARN_ON(zdev->state != ZPCI_FN_STATE_RESERVED); - if (zdev->zbus->bus) - zpci_bus_remove_device(zdev, false); - - if (zdev_enabled(zdev)) - zpci_disable_device(zdev); - if (zdev->has_hp_slot) zpci_exit_slot(zdev);