From: Aaron Lu <ziqianlu@bytedance.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Pu Lehui <pulehui@huawei.com>,
Luiz Capitulino <luizcap@amazon.com>,
Wei Wei <weiwei.danny@bytedance.com>,
Yuchen Zhang <zhangyuchen.lcr@bytedance.com>
Subject: Re: Host panic in bpf verifier when loading bpf prog in 5.10 stable kernel
Date: Mon, 23 Jun 2025 19:55:52 +0800 [thread overview]
Message-ID: <20250623115552.GA294@bytedance> (raw)
In-Reply-To: <2025062344-width-unvisited-a96f@gregkh>
On Mon, Jun 23, 2025 at 10:17:15AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 16, 2025 at 03:06:17PM +0800, Aaron Lu wrote:
> > Ping?
> >
> > On Thu, Jun 05, 2025 at 03:09:21PM +0800, Aaron Lu wrote:
> > > Hello,
> > >
> > > Wei reported when loading his bpf prog in 5.10.200 kernel, host would
> > > panic, this didn't happen in 5.10.135 kernel. Test on latest v5.10.238
> > > still has this panic.
> >
> > If a fix is not easy for these stable kernels, I think we should revert
> > this commit? Because for whatever bpf progs, the bpf verifier should not
> > panic the kernel.
> >
> > Regarding revert, per my test, the following four commits in linux-5.10.y
> > branch have to be reverted and after that, the kernel does not panic
> > anymore:
> > commit 2474ec58b96d("bpf: allow precision tracking for programs with subprogs")
> > commit 7ca3e7459f4a("bpf: stop setting precise in current state")
> > commit 1952a4d5e4cf("bpf: aggressively forget precise markings during
> > state checkpointing")
> > commit 4af2d9ddb7e7("selftests/bpf: make test_align selftest more
> > robust")
>
> Can you send the reverts for this, so that you get credit for finding
> and fixing this issue, and you can put the correct wording in the commit
> messages for why they need to be reverted?
No problem, thanks for the info.
I have sent them:
https://lore.kernel.org/stable/20250623115403.299-1-ziqianlu@bytedance.com/
next prev parent reply other threads:[~2025-06-23 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 7:09 Host panic in bpf verifier when loading bpf prog in 5.10 stable kernel Aaron Lu
2025-06-16 7:06 ` Aaron Lu
2025-06-23 8:17 ` Greg Kroah-Hartman
2025-06-23 11:55 ` Aaron Lu [this message]
2025-06-23 12:03 ` Greg Kroah-Hartman
2025-06-24 1:32 ` Pu Lehui
2025-06-24 3:52 ` Aaron Lu
2025-06-24 6:41 ` Pu Lehui
2025-06-24 10:33 ` Greg Kroah-Hartman
2025-06-25 9:33 ` Aaron Lu
2025-07-12 13:42 ` Greg Kroah-Hartman
2025-07-15 2:10 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623115552.GA294@bytedance \
--to=ziqianlu@bytedance.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=luizcap@amazon.com \
--cc=pulehui@huawei.com \
--cc=stable@vger.kernel.org \
--cc=weiwei.danny@bytedance.com \
--cc=zhangyuchen.lcr@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox