From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A219F13A265; Mon, 23 Jun 2025 13:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684674; cv=none; b=nUKOfnOex7EmhbItmJpe0UBE3w0EhpZRimIlS3XrqEKkO8dCP/OX83jDshaH3tuY4Mea5e6ENRSLppNXkOcgfw/gDVcQxk8vg71w2Vk/8KbqxvAOwXDXRtbeqLY4DcE+Sinxzl/uQraB8zN8gq4i1p2GM0HoCXtBVLz4LZXPozA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684674; c=relaxed/simple; bh=4ptBMOAwoTXM116T6qHVFLllOiDf/VT0+Cd29Pd3wsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NctHwtNLuW1fqChU5E7AraPjdEgtfrP4w9WsvGhYznx5nmSKIEXN4h+vPF4XO+G8cqxS+0QKebShn2n5Y/Z++oruCQ6A/tU8d/sb0WUUoG+9sQhedeIXJYpLzS6pn+Fi6NPfWOm/qTiGcSaTZjbKtjVZ9UUfIfXbOPkalIs07uQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VKhc8y0W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VKhc8y0W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3399C4CEEA; Mon, 23 Jun 2025 13:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750684674; bh=4ptBMOAwoTXM116T6qHVFLllOiDf/VT0+Cd29Pd3wsI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VKhc8y0WLGcpzrmZj20ZgBL49jOQFZAqZBovsSN5NPtiP/LuHxQJCqZgBsONaAoWa qvqL/rdCLDm/cCTPK9iQxuVs2lOWn1T0JZRzoVFyXc6Lu9qper2GDIuYtu9Jn86zY3 bro1QSoanpBM0Fx0kTPAbS2hlGta/lYh6FnbFxcw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sergey Senozhatsky , Mika Westerberg Subject: [PATCH 5.4 007/222] thunderbolt: Do not double dequeue a configuration request Date: Mon, 23 Jun 2025 15:05:42 +0200 Message-ID: <20250623130612.120933859@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sergey Senozhatsky commit 0f73628e9da1ee39daf5f188190cdbaee5e0c98c upstream. Some of our devices crash in tb_cfg_request_dequeue(): general protection fault, probably for non-canonical address 0xdead000000000122 CPU: 6 PID: 91007 Comm: kworker/6:2 Tainted: G U W 6.6.65 RIP: 0010:tb_cfg_request_dequeue+0x2d/0xa0 Call Trace: ? tb_cfg_request_dequeue+0x2d/0xa0 tb_cfg_request_work+0x33/0x80 worker_thread+0x386/0x8f0 kthread+0xed/0x110 ret_from_fork+0x38/0x50 ret_from_fork_asm+0x1b/0x30 The circumstances are unclear, however, the theory is that tb_cfg_request_work() can be scheduled twice for a request: first time via frame.callback from ring_work() and second time from tb_cfg_request(). Both times kworkers will execute tb_cfg_request_dequeue(), which results in double list_del() from the ctl->request_queue (the list poison deference hints at it: 0xdead000000000122). Do not dequeue requests that don't have TB_CFG_REQUEST_ACTIVE bit set. Signed-off-by: Sergey Senozhatsky Cc: stable@vger.kernel.org Signed-off-by: Mika Westerberg Signed-off-by: Greg Kroah-Hartman --- drivers/thunderbolt/ctl.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -131,6 +131,11 @@ static void tb_cfg_request_dequeue(struc struct tb_ctl *ctl = req->ctl; mutex_lock(&ctl->request_queue_lock); + if (!test_bit(TB_CFG_REQUEST_ACTIVE, &req->flags)) { + mutex_unlock(&ctl->request_queue_lock); + return; + } + list_del(&req->list); clear_bit(TB_CFG_REQUEST_ACTIVE, &req->flags); if (test_bit(TB_CFG_REQUEST_CANCELED, &req->flags))