From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42F47258CE5; Mon, 23 Jun 2025 13:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684797; cv=none; b=E71ri3c39w8WIauGpTfMHoViiun62RX7LPqrzWAD7FYb4rBmofoTfCYGi9QtIgs6U85Xi7vBBk6e7pXWiAHhAmaxz4jFbLX0civYwCqAYnk/EkJdpB+LO7D3lyyW4S0XWeQ7JJ+OMwUFle50cfOh8cw1KUZWei9H3iHUIN6/F3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684797; c=relaxed/simple; bh=11yR34aflEu7Esub+CK0KcIQrHuPdlcHaFeXh2XMcFc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kso1Pc6sB8oLCKICxCcYeWPPxebLO1HN1iv96rrmfaz9sYWn6Z/zXTWpcvDsjzZ2D3Xco6Ys+m4itedv2o3u0/ONdaMiVO6GrI6UIB2PoMMLPlipFp+y9v9gAkUvkoIDwcZp1mdVXih49gUSqVXVeSPOjkPdJprtoDZJZT5jRsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dV5yibi+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dV5yibi+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB00DC4CEEA; Mon, 23 Jun 2025 13:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750684797; bh=11yR34aflEu7Esub+CK0KcIQrHuPdlcHaFeXh2XMcFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dV5yibi+7mpfDKvStpDv0QfRvEuNv8W5Oo9fcrcgeGOXRx4XBPzekTbq1JuxPgNeJ uzG0jVVOoq+tQluv2qpvBW+qL5qCVzzNw6cw+0NIKdspQfINHU96NP7YASAv1pnp7t GL3QUdnQDKnBo6WYIrORDh9ntMJ72+tW6x7cyWDg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Neill Kapron , Kees Cook , Sasha Levin Subject: [PATCH 5.4 022/222] selftests/seccomp: fix syscall_restart test for arm compat Date: Mon, 23 Jun 2025 15:05:57 +0200 Message-ID: <20250623130612.570120696@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Neill Kapron [ Upstream commit 797002deed03491215a352ace891749b39741b69 ] The inconsistencies in the systcall ABI between arm and arm-compat can can cause a failure in the syscall_restart test due to the logic attempting to work around the differences. The 'machine' field for an ARM64 device running in compat mode can report 'armv8l' or 'armv8b' which matches with the string 'arm' when only examining the first three characters of the string. This change adds additional validation to the workaround logic to make sure we only take the arm path when running natively, not in arm-compat. Fixes: 256d0afb11d6 ("selftests/seccomp: build and pass on arm64") Signed-off-by: Neill Kapron Link: https://lore.kernel.org/r/20250427094103.3488304-2-nkapron@google.com Signed-off-by: Kees Cook Signed-off-by: Sasha Levin --- tools/testing/selftests/seccomp/seccomp_bpf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 19c7351eeb74b..a12eea3aff104 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -2875,12 +2875,15 @@ TEST(syscall_restart) ret = get_syscall(_metadata, child_pid); #if defined(__arm__) /* - * FIXME: * - native ARM registers do NOT expose true syscall. * - compat ARM registers on ARM64 DO expose true syscall. + * - values of utsbuf.machine include 'armv8l' or 'armb8b' + * for ARM64 running in compat mode. */ ASSERT_EQ(0, uname(&utsbuf)); - if (strncmp(utsbuf.machine, "arm", 3) == 0) { + if ((strncmp(utsbuf.machine, "arm", 3) == 0) && + (strncmp(utsbuf.machine, "armv8l", 6) != 0) && + (strncmp(utsbuf.machine, "armv8b", 6) != 0)) { EXPECT_EQ(__NR_nanosleep, ret); } else #endif -- 2.39.5