From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 226AA2367B0; Mon, 23 Jun 2025 13:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685116; cv=none; b=s/lBzM09XU4kMh2Irfj3bLE/MF7rUtRhqVf6ABYuWnVlsFBjFrGZ6xfJoUWBugCLJcfBSALMKWx6bWA0GNMd6uGzDFIjmoFjXKqH5iBuG+o3TQ88gr/Lab0IbOOV33s3zMuwwwiBSrDCtAcfPSoyQeEWzeKOSKxlobbiv0JmzpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685116; c=relaxed/simple; bh=HjI85lwkhzT855j0JQIuCdmHxziAHGxwOnyiODrqbfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tsV2jNtFZRiiX4+IlDSu/BSDOSPnvBMRLQcPYx7w09mDz0BI68EenjlHC3eOji9PpAkCXB7lH6p8tR01W8rQpvDpFTS236P7jwvKJyR/XXm6LPrxcSmqVY6UklA/I9SbA1SHZivejD/6SzX6lChEHyYBtquIShphethUeFy+vEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K+OggrV5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K+OggrV5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B908C4CEEA; Mon, 23 Jun 2025 13:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750685115; bh=HjI85lwkhzT855j0JQIuCdmHxziAHGxwOnyiODrqbfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K+OggrV5u3fGh0pdykL9EmACatNjxGoKoe4ELg4QKGoSeU4HHBFxCsMkpDGQZoFWn rntK23u4fZGkyqmQwsf/mgF1eg48uqEP/bb16Yw5vGeDa8QX9I2ImFnzpWt77F1RuB uAON8aOELSjU+C4qrbVQDkOdyIOgrmCBVDS9U+fw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 5.4 067/222] net/mlx4_en: Prevent potential integer overflow calculating Hz Date: Mon, 23 Jun 2025 15:06:42 +0200 Message-ID: <20250623130614.121954310@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 54d34165b4f786d7fea8412a18fb4a54c1eab623 ] The "freq" variable is in terms of MHz and "max_val_cycles" is in terms of Hz. The fact that "max_val_cycles" is a u64 suggests that support for high frequency is intended but the "freq_khz * 1000" would overflow the u32 type if we went above 4GHz. Use unsigned long long type for the mutliplication to prevent that. Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW frequency") Signed-off-by: Dan Carpenter Reviewed-by: Simon Horman Link: https://patch.msgid.link/aDbFHe19juIJKjsb@stanley.mountain Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx4/en_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_clock.c b/drivers/net/ethernet/mellanox/mlx4/en_clock.c index 024788549c256..060698b0c65cc 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_clock.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_clock.c @@ -251,7 +251,7 @@ static const struct ptp_clock_info mlx4_en_ptp_clock_info = { static u32 freq_to_shift(u16 freq) { u32 freq_khz = freq * 1000; - u64 max_val_cycles = freq_khz * 1000 * MLX4_EN_WRAP_AROUND_SEC; + u64 max_val_cycles = freq_khz * 1000ULL * MLX4_EN_WRAP_AROUND_SEC; u64 max_val_cycles_rounded = 1ULL << fls64(max_val_cycles - 1); /* calculate max possible multiplier in order to fit in 64bit */ u64 max_mul = div64_u64(ULLONG_MAX, max_val_cycles_rounded); -- 2.39.5