From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F1E4C7F; Mon, 23 Jun 2025 13:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685612; cv=none; b=Jpez6runNrNkKKQkJ/PdjOmHqM0LuAND3FAFuUecP/EEgSBFC7UOaas7CXKtR3OG/XCNoV/gmeISiReQYU1fj9DIEsrXNGyYRXAVkKbS4qPlGRk74sJ2HHWf299yeuFg18mJl8B8qqP+eF3ULnBlIjUYbtWn3wsRHpn38JbySPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685612; c=relaxed/simple; bh=s+1Adq8DJmoG78cDwj9aPBfaoqP0OkUBvCPHPdh2XmM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ojtrRPcTapgLXszi2SmPDkXwTEdTxXj/rZYGytPxAsNk6vRuqgb3rgSe+xlnwp6gRtJc+ELteZ2SJ611nl2JkOwXg1VlKh8Jyv3A/PgRFo76v8y6Coepr5SU51cSvJID6gCi1C7mmSkwlMgtG45NQosT0B/PAYFp/5TV5InB5Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rAnjoXiC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rAnjoXiC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1C02C4CEEA; Mon, 23 Jun 2025 13:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750685611; bh=s+1Adq8DJmoG78cDwj9aPBfaoqP0OkUBvCPHPdh2XmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rAnjoXiCj3GWqb9is8siCswD0ow0V1SIqJESQSTZ6MtzVbI+9JcUY+oflRGn5JeeI 3gUhROhDmkVVUvXHtDyDSL0VoSEos3X4Xgb7Vi/J8NfsvL8vRHeDzIyW3Z1lex/3Ti wIe5Lo13FZN5QceXiFv/4fKKv6FtcHeiW4PGNhzw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Hans Verkuil Subject: [PATCH 5.4 107/222] media: gspca: Add error handling for stv06xx_read_sensor() Date: Mon, 23 Jun 2025 15:07:22 +0200 Message-ID: <20250623130615.328478728@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang commit 398a1b33f1479af35ca915c5efc9b00d6204f8fa upstream. In hdcs_init(), the return value of stv06xx_read_sensor() needs to be checked. A proper implementation can be found in vv6410_dump(). Add a check in loop condition and propergate error code to fix this issue. Fixes: 4c98834addfe ("V4L/DVB (10048): gspca - stv06xx: New subdriver.") Cc: stable@vger.kernel.org # v2.6+ Signed-off-by: Wentao Liang Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c +++ b/drivers/media/usb/gspca/stv06xx/stv06xx_hdcs.c @@ -520,12 +520,13 @@ static int hdcs_init(struct sd *sd) static int hdcs_dump(struct sd *sd) { u16 reg, val; + int err = 0; pr_info("Dumping sensor registers:\n"); - for (reg = HDCS_IDENT; reg <= HDCS_ROWEXPH; reg++) { - stv06xx_read_sensor(sd, reg, &val); + for (reg = HDCS_IDENT; reg <= HDCS_ROWEXPH && !err; reg++) { + err = stv06xx_read_sensor(sd, reg, &val); pr_info("reg 0x%02x = 0x%02x\n", reg, val); } - return 0; + return (err < 0) ? err : 0; }