From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E24A347DD; Mon, 23 Jun 2025 13:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685818; cv=none; b=P5TmcPf/KSqnANyzUNah1ySgFnrfD51L8a35w2ac7+7LsA67l7/PrrC9i28Mn4eSpi4lnLAPqTinO1YILyJ/hp0WxHP3XAS3qoCG6E51ZtGVKgCwQXYMEhvYtSlHmoTnTxPToQgkay9pL7xSiFf/igMzKLr1egryrk/G/5pCApI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685818; c=relaxed/simple; bh=Vm0L+E8HU+99ldCD6zUsjPEx91ykVAJ8WHum1T84nCc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=srL0qEqxf06h8N4uoLAmbj3IKjZckhUAg7256Rt4RLdKgR8I0oeoCPMt6tVJ3j5JsxO1lYzhFvl1Inhoa62soO4QpQFNaOuMcJxklPH6gphHqE9oWl1dI6O892iPOAO1SnCc5xqwLaIU7kIQ6cjQpD4xb0LP+a0SEgW2Bj5lHSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XN48kxpJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XN48kxpJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96CB0C4CEEA; Mon, 23 Jun 2025 13:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750685817; bh=Vm0L+E8HU+99ldCD6zUsjPEx91ykVAJ8WHum1T84nCc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XN48kxpJpdewwnC4r7nULMP/ywE0LUDYzXOrr0Bbv9aY9LGZKG9JOWSLF9zdI1Gtq xVRXRSh6/1i77dLyTWoUTmRFf9FbWtROogeBbOANY6vmTngAJRZxnylmuaUFdxuBHu KxH+2UUrsWHaLhKZnXF83nEpiC2weH8FD7qP+EqA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Douglas Anderson , Damon Ding , Dmitry Baryshkov , Sasha Levin Subject: [PATCH 5.4 143/222] drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of calling disable_irq() Date: Mon, 23 Jun 2025 15:07:58 +0200 Message-ID: <20250623130616.389516178@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Damon Ding [ Upstream commit efab13e7d13a641a22c7508cde6e1a5285161944 ] The IRQF_NO_AUTOEN can be used for the drivers that don't want interrupts to be enabled automatically via devm_request_threaded_irq(). Using this flag can provide be more robust compared to the way of calling disable_irq() after devm_request_threaded_irq() without the IRQF_NO_AUTOEN flag. Suggested-by: Douglas Anderson Reviewed-by: Douglas Anderson Signed-off-by: Damon Ding Link: https://lore.kernel.org/r/20250310104114.2608063-2-damon.ding@rock-chips.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index df606a5675663..234c0bd38e851 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1735,10 +1735,10 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) * that we can get the current state of the GPIO. */ dp->irq = gpiod_to_irq(dp->hpd_gpiod); - irq_flags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING; + irq_flags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN; } else { dp->irq = platform_get_irq(pdev, 0); - irq_flags = 0; + irq_flags = IRQF_NO_AUTOEN; } if (dp->irq == -ENXIO) { @@ -1755,7 +1755,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) dev_err(&pdev->dev, "failed to request irq\n"); goto err_disable_clk; } - disable_irq(dp->irq); return dp; -- 2.39.5