From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B48C070838; Mon, 23 Jun 2025 21:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750712997; cv=none; b=MKjDGYCYv/No45SIkEhosJjNm9D7H+fMXkat+9YMg16XXJgwLqZiCzmiCpbh8tg+gRZGE7cvwmxiiYD3CwNgqD/sNIu+a2EOt9NQryHzTifRIgPm+MSW8QGfSdlNgPvx9v6OPGEk92R2tYRw/Y1ibEssQ9MDi5mKU7JHJSz2bxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750712997; c=relaxed/simple; bh=5bTG7OY069AeVmSdp7rxuHugQzhk1XzjPqx8pM1yij8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VuxHrkQoAYitUdHX1KM3O0xyM36JeLxbSddAukgl7equG8SbD11vtC9TF9A6qEZY6WXXEu5kDvlmylTEcWOSBeHavRRzAG+3BXR3Eo8cTdzwLoe+9hlW53i5/T86QvFlR1rigUKb1cSijePDnTFRPOSoGNNQ8qOrRc5OZ80IE+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qlzu6SA5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qlzu6SA5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29004C4CEEA; Mon, 23 Jun 2025 21:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750712997; bh=5bTG7OY069AeVmSdp7rxuHugQzhk1XzjPqx8pM1yij8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qlzu6SA5MvcIGvUej0hJhyONn0ibrrFjlQNJnxtAyxPoa6Umdt0Mn6V7LPnEfYbJA YLaWDFD2DD7Xzv2G/U7ITdCp7cWq6mXV/O5/+4hZ59pyz4qBqokX9hnDhxxZWevC9C 2J6kxbpBunrDc6K//DtGOWRw+JPIjffp+hSrA2sE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sergio Perez Gonzalez , Claudiu Beznea , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 159/222] net: macb: Check return value of dma_set_mask_and_coherent() Date: Mon, 23 Jun 2025 15:08:14 +0200 Message-ID: <20250623130616.862313870@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sergio Perez Gonzalez [ Upstream commit 3920a758800762917177a6b5ab39707d8e376fe6 ] Issue flagged by coverity. Add a safety check for the return value of dma_set_mask_and_coherent, go to a safe exit if it returns error. Link: https://scan7.scan.coverity.com/#/project-view/53936/11354?selectedIssue=1643754 Signed-off-by: Sergio Perez Gonzalez Reviewed-by: Claudiu Beznea Link: https://patch.msgid.link/20250526032034.84900-1-sperezglz@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/cadence/macb_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index a750c752846cf..a635c9af26c3e 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4320,7 +4320,11 @@ static int macb_probe(struct platform_device *pdev) #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT if (GEM_BFEXT(DAW64, gem_readl(bp, DCFG6))) { - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(44)); + err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(44)); + if (err) { + dev_err(&pdev->dev, "failed to set DMA mask\n"); + goto err_out_free_netdev; + } bp->hw_dma_cap |= HW_DMA_CAP_64B; } #endif -- 2.39.5