From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AED01DF98B; Mon, 23 Jun 2025 21:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713258; cv=none; b=Ute8BVpHoaIgsjDfduO3glv4dz+okNiBhOBEwSdy8ILNVKuLCql48aNpAMASGYkhp6rqvv7jh9Zt7P2RQOfQe8HYhQwcFrU2EbtaGshjk+YIxLvXCJrdPvjONSCm9979thkRIfE7VioTE+h3NKhivmppw9/rNzNFlNwTa0V/LzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713258; c=relaxed/simple; bh=74u9hILTxoYG+SSl/1Q31ZzJ7aKkLcjfmUUGcei6HmM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EUXdc6rjKZwKBHu7xA2WSSOkFeYLLy2L9xbFfH3Zi8ZbpU3HYFRx3ctTx5zuk3+G330KqzCjY9yMcq2pAIlSwElKqY9VafXHlHU+U56U+DT4r0OGN3v0loeFxgnmeD1sk16eANGeyJgPRxmN87Z75FRGdyYyrFbaNehOBWR4CBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2grbFcl2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2grbFcl2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5631C4CEEA; Mon, 23 Jun 2025 21:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750713258; bh=74u9hILTxoYG+SSl/1Q31ZzJ7aKkLcjfmUUGcei6HmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2grbFcl2QwVokuyFfQxjuP/ItNZciD4Fy3HATQ6DMBGo9d5PyDdaGcuiQR0mivlQL 5uQWWG9cT7NMD+BHBajK3lOJtAzn1oBfMfwsJja7gIOaWowkb55aCwgjWyUgSlV8Am x0TxfK1Gk8GwtlXQJ5prkx2JhuI2o5iltzQbicZw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Imre Kaloz , Andrew Lunn , Gabor Juhos , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 169/222] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction() Date: Mon, 23 Jun 2025 15:08:24 +0200 Message-ID: <20250623130617.156062815@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gabor Juhos [ Upstream commit bfa0ff804ffa8b1246ade8be08de98c9eb19d16f ] The armada_37xx_gpio_direction_{in,out}put() functions can fail, so propagate their error values back to the stack instead of silently ignoring those. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-5-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index d3d156b25e96d..4df9dbad0e977 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -464,16 +464,17 @@ static int armada_37xx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, { struct armada_37xx_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); struct gpio_chip *chip = range->gc; + int ret; dev_dbg(info->dev, "gpio_direction for pin %u as %s-%d to %s\n", offset, range->name, offset, input ? "input" : "output"); if (input) - armada_37xx_gpio_direction_input(chip, offset); + ret = armada_37xx_gpio_direction_input(chip, offset); else - armada_37xx_gpio_direction_output(chip, offset, 0); + ret = armada_37xx_gpio_direction_output(chip, offset, 0); - return 0; + return ret; } static int armada_37xx_gpio_request_enable(struct pinctrl_dev *pctldev, -- 2.39.5