From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 131D74C62; Mon, 23 Jun 2025 21:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713339; cv=none; b=YtW5JSkWnD2Wf0ucz4wAIy2WTfWBkf/cMkSSm2cB3jl791anQe1Yg6AWF1vqap08i7XV7AKsoJlTD+MOOOZFsPAULP4rhEdNNKWCn2KV3IMytN6B4VstN2M/X4JVjc+wuBwDH6QzJwZRF7HpFK9NhV828gFGOWofG28jCNH0FAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713339; c=relaxed/simple; bh=Vur2IcnS41a1tdoZZJ4D4yT9iw8xfITamPST31lBDOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LPcQ5yhJ9EKzIXk4fPaX2bJQDX4QMJmJn3I3w1bYdGkO7YUKa/H7XIpWoS8CnjGsbovfwMezwHgXGIuRS450XVbpZY6QBFPvMiq2Rzhgjmv1ZLmx2MQP+ZLlcd/C4StkGdO1YNsKQo4N3T1DWzxmNCeYgKobu5cQZoTiJ+uf/ic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PP5wDpX7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PP5wDpX7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97593C4CEEA; Mon, 23 Jun 2025 21:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750713338; bh=Vur2IcnS41a1tdoZZJ4D4yT9iw8xfITamPST31lBDOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PP5wDpX7h1ExYWf2h8ztqfqj2rEmH5xSw1Snunn78wUwvs+IIZ8tqVunknp8zmhsR PvdJcngYZmEsVyPEFY+IH/HChXtEgcV1qqj2SrFN0IooGkX32UVsC6PR9nxpNNXYfl l+u0Vj8nzvxrmhCy1mQ8WKvAdiBLoOfZqk4e+e/A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Imre Kaloz , Andrew Lunn , Gabor Juhos , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 170/222] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get() Date: Mon, 23 Jun 2025 15:08:25 +0200 Message-ID: <20250623130617.186242318@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130611.896514667@linuxfoundation.org> References: <20250623130611.896514667@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gabor Juhos [ Upstream commit 57273ff8bb16f3842c2597b5bbcd49e7fa12edf7 ] The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-4-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 4df9dbad0e977..46e7e78d37632 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -435,11 +435,14 @@ static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = INPUT_VAL; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; return (val & mask) != 0; } -- 2.39.5