From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C440239E63; Mon, 23 Jun 2025 13:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685136; cv=none; b=b4fWmRVZm/hdzzU71EuL/85A0YLkFj+pNfcuFYL7qjQZUZm869VFEG8oj5rVsX1RGHszrmZPLs5Wsn2PCPcrxwnKXC4deIomGbBzoK555m9xm7njINZWKJKZWHZSHM8DjyyVD3m0V2SqMR1GERjP/VqEImb1Hfjgwknd6pmGg08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685136; c=relaxed/simple; bh=eFE8Anr/pr3H1FSDwGMYDEo6+A09bDUpSmJYZ9C72pA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qXfkYhbaPX7tTWQdzfvgg0fVvLfOwO3rNblyDsnXO4Q6WSp3RS2Jx0QNIhei7DR4HAQEmZcUCxiNGP2/D0ZkTFKcNlEnUdlzJenn/KjJ25EgGMFwJlfxYtOcxmz5o7ZrPwRrkiN5z0jrMVcybsKZckCZGaLNr7S48KJGpzwj3Rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bD5RweAr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bD5RweAr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FEB6C4CEEA; Mon, 23 Jun 2025 13:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750685136; bh=eFE8Anr/pr3H1FSDwGMYDEo6+A09bDUpSmJYZ9C72pA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bD5RweArE6v+0443kMFSokVY4266P0M3rMYyFz+31E6BSTjP5tQN2QtJFGid5z4MQ l8ivsNPqmCOAhN1/UmSkdm4vdjYB28F1HFd5uPkj+v7VngCfWQwtr289Vkxw0QNPbp hXIDCjUo2ffHLrbtiYhErpMdia1BEmFVXeViug14= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Neill Kapron , Kees Cook , Sasha Levin Subject: [PATCH 5.10 029/355] selftests/seccomp: fix syscall_restart test for arm compat Date: Mon, 23 Jun 2025 15:03:50 +0200 Message-ID: <20250623130627.686681694@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Neill Kapron [ Upstream commit 797002deed03491215a352ace891749b39741b69 ] The inconsistencies in the systcall ABI between arm and arm-compat can can cause a failure in the syscall_restart test due to the logic attempting to work around the differences. The 'machine' field for an ARM64 device running in compat mode can report 'armv8l' or 'armv8b' which matches with the string 'arm' when only examining the first three characters of the string. This change adds additional validation to the workaround logic to make sure we only take the arm path when running natively, not in arm-compat. Fixes: 256d0afb11d6 ("selftests/seccomp: build and pass on arm64") Signed-off-by: Neill Kapron Link: https://lore.kernel.org/r/20250427094103.3488304-2-nkapron@google.com Signed-off-by: Kees Cook Signed-off-by: Sasha Levin --- tools/testing/selftests/seccomp/seccomp_bpf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 413a7b9f3c4d3..7f62635226fd3 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -3081,12 +3081,15 @@ TEST(syscall_restart) ret = get_syscall(_metadata, child_pid); #if defined(__arm__) /* - * FIXME: * - native ARM registers do NOT expose true syscall. * - compat ARM registers on ARM64 DO expose true syscall. + * - values of utsbuf.machine include 'armv8l' or 'armb8b' + * for ARM64 running in compat mode. */ ASSERT_EQ(0, uname(&utsbuf)); - if (strncmp(utsbuf.machine, "arm", 3) == 0) { + if ((strncmp(utsbuf.machine, "arm", 3) == 0) && + (strncmp(utsbuf.machine, "armv8l", 6) != 0) && + (strncmp(utsbuf.machine, "armv8b", 6) != 0)) { EXPECT_EQ(__NR_nanosleep, ret); } else #endif -- 2.39.5